Failed assertion during APPEND

[Jan Schneider]

APPENDing a message results in "Fatal error: Internal error: assertion failed:
mailbox.c: 2180: !message_guid_isnull(&record->guid)"

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[KWAndi (lst-hoe01)]

A "debdiff" for simply including the one-line fix:

diff -Nru cyrus-imapd-2.4-2.4.12/debian/patches/cyrus-imapd-assertion-on-binary-append.patch cyrus-imapd-2.4-2.4.12/debian/patches/cyrus-imapd-assertion-on-binary-append.patch
--- cyrus-imapd-2.4-2.4.12/debian/patches/cyrus-imapd-assertion-on-binary-append.patch 1970-01-01 01:00:00.000000000 +0100
+++ cyrus-imapd-2.4-2.4.12/debian/patches/cyrus-imapd-assertion-on-binary-append.patch 2013-06-13 16:30:47.000000000 +0200
@@ -0,0 +1,11 @@
+--- a/imap/message.c 2013-06-13 16:03:20.000000000 +0200
++++ b/imap/message.c 2013-06-13 16:23:25.646533635 +0200
+@@ -371,6 +371,8 @@
+ message_parse_body(&msg, *body,
+ DEFAULT_CONTENT_TYPE, (struct boundary *)0);
+
++ message_guid_generate(&(*body)->guid, msg.base, msg.len);
++
+ lseek(fd, 0L, SEEK_SET);
+ n = retry_write(fd, msg.base, msg.len);
+
diff -Nru cyrus-imapd-2.4-2.4.12/debian/patches/series cyrus-imapd-2.4-2.4.12/debian/patches/series
--- cyrus-imapd-2.4-2.4.12/debian/patches/series 2011-10-06 21:53:48.000000000 +0200
+++ cyrus-imapd-2.4-2.4.12/debian/patches/series 2013-06-13 16:35:48.000000000 +0200
@@ -28,5 +28,6 @@
 82-fix_manpage_errors.patch
 cyrus-imapd-2.4.2-902-accept-invalid-from-header.patch
 cyrus-imapd-2.4.2-903-normalize-authorization-id.patch
+cyrus-imapd-assertion-on-binary-append.patch
 86-fix_PATH_MAX_on_hurd.patch
 87-try_only_-ldb.patch

[Dmitry Shachnev (mitya57)]

Please add a changelog entry to your debdiff. Also, Debian maintainers seem to be preparing a new upstream release in their Git, so we can get this fixed via Debian.

[KWAndi (lst-hoe01)]

Hello,

not sure if this fix is included in upstream Debian, nor how to check :-(

If it should better get included there it would be nice to know how to get it there. Any pointers available?

[Iain Lane (laney)]

It is - I looked in their packaging repository:

  http://anonscm.debian.org/gitweb/?p=pkg-cyrus-imapd/cyrus-imapd-2.4.git;a=blob;f=imap/message.c;h=6a0e42024cfb94a86d043266fc62332570226d30;hb=HEAD#l374

So we'll get this for free when 2.4.17 gets into Debian and someone syncs it.

If you want to get this into Raring/other stable Ubuntu releases then please follow the Stable Release Update procedure

  https://wiki.ubuntu.com/StableReleaseUpdates#Procedure

 (step 3 - you don't strictly need to prepare a debdiff; that's quite easy for a sponsor to do from the patch already on this bug).

I'm going to unsubscribe the sponsors now but please do resubscribe if you want the SRU and have updated the description with the required information.

Thanks for your help so far. :-)