Scrolling over tabs should switch tabs

Bug #1077958 reported by On-The-Fly
20
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Wishlist
Julien Spautz

Bug Description

If you put your mouse over any tab and scroll the tabs should switch like in most other linux applications like chromium-browser, sublime-text or gnome-terminal.

Scrolling up would mean last tab, scrolling down next tab.

Tags: scroll tabs

Related branches

David Gomes (davidgomes)
Changed in elementaryos:
status: New → Invalid
no longer affects: elementaryos
Changed in pantheon-terminal:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → luna-beta2
Revision history for this message
Akshay Shekher (voldyman) wrote :

this is a more of a granite DynamicNotebook issue than a pantheon terminal issue.

Revision history for this message
apart (iapart) wrote :

Hi, I finally had a moment to find why the keys weren't correctly captured in DynamicNotebook.
I moved the keyboard event registration piece in to the set_parent event handler and registered the events to the toplevel window. This way the tab switching hotkeys (ctr+tab, shift+tab, etc.) are captured and handled correctly.
I attach a diff file for this.

Revision history for this message
David Gomes (davidgomes) wrote :

Apart, I don't really get the patch. First of all, it's based on an old Dynamic Notebook version and then I don't get what you are trying to do. This has nothing to do with using the mouse wheel over tabs does it?

Ctrl+Tab and Ctrl+Shift+Tab are NOT supposed to work on the Terminal by the way.

Revision history for this message
apart (iapart) wrote : Re: [Bug 1077958] Re: Scrolling over tabs should switch tabs

Hi,

I don't know about the dynamic notebook being up-to-date - I checked
out the current version from bzr and based on that. I got confused with
the tickets for key and mouse bindings - so I posted the patch to two
different tickets.

The patch is for ctrl+tab and ctr+shift+tab - if these are NOT supposed
to work in terminal then what is? Ctrl+Pg{Up,Dn} ? Ctrl+tab are the ones
mentioned in the comment in DynamicNotebook. They weren't working,
because the handler was attached to a wrong object - and that's what
my patch does - it grabs the main window (in on_parent_set event)
and attaches the ctrl+tab handler in that window. I think that's the only
way to handle this event (same holds for ctrl+PgUp).

a.

Revision history for this message
Danielle Foré (danrabbit) wrote :

Removing from milestone since this is a Granite issue and not really a Terminal issue

Changed in pantheon-terminal:
milestone: luna-beta2 → none
David Gomes (davidgomes)
Changed in pantheon-terminal:
status: Confirmed → Invalid
Changed in granite:
status: New → Confirmed
importance: Undecided → Medium
milestone: none → luna-beta3
Cody Garver (codygarver)
Changed in granite:
importance: Medium → Wishlist
milestone: luna-beta3 → none
no longer affects: pantheon-terminal
Changed in granite:
status: Confirmed → In Progress
assignee: nobody → Julien Spautz (julien-spautz)
David Gomes (davidgomes)
Changed in granite:
status: In Progress → Fix Released
milestone: none → luna-beta2
Revision history for this message
Stego (stegomon) wrote :

i absolutely NEED the <CTRL>+<PgUp>/<PgDown> tab navigation between tabs!
please implement this ASAP!
thanks!

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.