[MIR] webaccounts-browser-extension

[Ken VanDine]

We need to get xul-ext-webaccounts ready to include in the default install.

[Michael Terry (mterry)]

Didier, Ken mentioned that this was useful short-term. I'm gone tomorrow and Monday, so if you could look at this, I'd appreciate it.

[Didier Roche-Tolomelli (didrocks)]

Hey ken,

Two things needs to be fixed IMHO:
* debian/copyright:
- the files under lib/* are GPL2+ and are not really listed in that file, can you please fix that?
* build-dep on vim-common? are you sure? ;)

the rests are more questions:
* debian/xul-ext-webaccounts.postinst:
only firefox needs to be restarted, nothing else?
* how can I test it? like, if I install the extension, I should go to my gmail account (without being logged) and online account will log for me?
* how do you want to deal installing that by default? Seeding the firefox plugin, letting chromium users installing it themselves? adding them as recommends by default? (what about other flavors?). Looking at the js code, it seems the other way aroud: if I login to gmail in a page, it will extract and we'll get the credential stored in addition to chromium in uoa.

* Not related to that directly, but as you are changing the packaging anyway:
- for coherence reason, can you try having all build-deps on top? (likes debhelper, dh_autoreconf, quilt… then upstream build requirement, gcc, vala… and then what is needed for autoreconf, like gnome-common?)

Otherwise, the codes looks good, I didn't see anything dangerous after a look at the javascript.
the chrome manifest is using version 2 if I see correctly! I love it :)

[Ken VanDine (ken-vandine)]

I fixed those issues in 0.4.5-0ubuntu3

Chromium does need to be restarted to see the extension, just like firefox but I don't think our chromium package has a standard way to trigger that like firefox does. I'll investigate that.

To test it, switch to a guest session, open firefox, login to twitter.com, you should see the online account panel from g-c-c raised adding the credential.

I think best way to handle seeding it is to add it as a recommends to firefox and chromium. However, seeding xul-ext-webaccounts as a recommends in ubuntu-desktop might be more friendly for derivatives.

[Didier Roche-Tolomelli (didrocks)]

Ok, looks good to me, please add the seed and deps on it and I'll promote the xul component.

FYI, I tested using gmail, it indeed opened g-c-c, but with no prefiled credential, is that intended?

[Adam Conrad (adconrad)]

Promoted.