TypeError: decoding Unicode is not supported: "embedimage.py", line 72

[Aapo Rantalainen]

LANG: fi_FI.UTF-8
Python: 2.7.3
Inkscape: 0.48.3.1-1ubuntu1
Linux 3.2.0-27-generic #43-Ubuntu SMP Fri Jul 6 14:25:57 UTC 2012 x86_64 x86_64 x86_64 GNU/Linux

This is reproducible with large (non-releasable production) file. I'm still looking smallest test case to reproduce it.

Svg-file with linked png-images. Some image might have changed places (in filesystem), but everything is visible correctly.

Fields "sodipodi:absref" and/or "xlink:href" contain non-ascii characters (namely 'ö' and 'ä').

"Extensions" -> "Images" -> "Embed images...":

Traceback (most recent call last):
 File "embedimage.py", line 106, in <module>
   e.affect()
 File "/usr/local/share/inkscape/extensions/inkex.py", line 247, in affect
   self.effect()
 File "embedimage.py", line 38, in effect
   self.embedAll(self.document)
 File "embedimage.py", line 52, in embedAll
   self.embedImage(node)
 File "embedimage.py", line 72, in embedImage
   path=unicode(path, "utf-8")
TypeError: decoding Unicode is not supported

Workaround:
            path=''
            #path selection strategy:
            # 1. href if absolute
            # 2. realpath-ified href
            # 3. absref, only if the above does not point to a file
            if (href != None):
                path=os.path.realpath(href)
            if (not os.path.isfile(path)):
                if (absref != None):
                    path=absref

-path=unicode(path, "utf-8")
+try:
+ path=unicode(path, "utf-8")
+except TypeError:
+ path=path

Seems all path selection strategy is not returning in same format (unicode/utf8).

[jazzynico (jazzynico)]

Confirmed on Windows XP, Inkscape trunk revision 11871.

[jazzynico (jazzynico)]

Patch tested successfully on Windows.
Thanks for your help!

[jazzynico (jazzynico)]

Fix committed in the trunk, revision 11877.
Thanks!

[jazzynico (jazzynico)]

Backported to the branch, revision 9930.