Camera capture crashes on Galaxy Nexus

[vishal]

Camera capture crashes on Galaxy Nexus and the PC points to a memcpy operation. It could be a bug in the optimized memcpy function.

Here is the stack trace:

V/camera ( 5543): mAutoFocusTime = 1783ms
V/camera ( 5543): Preview size is 960x720
V/camera ( 5543): onShutterButtonClick: mCameraState=1
F/libc ( 3701): Fatal signal 7 (SIGBUS) at 0x00000000 (code=128), thread 3709 (Binder_1)
I/DEBUG ( 127): *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** ***
I/DEBUG ( 127): Build fingerprint: 'Android/full_maguro/maguro:4.1.2/JZO54K/eng.bero.20121027.105210:eng/test-keys'
I/DEBUG ( 127): pid: 3701, tid: 3709, name: Binder_1 >>> /system/bin/mediaserver <<<
I/DEBUG ( 127): signal 7 (SIGBUS), code 128 (?), fault addr 00000000
I/DEBUG ( 127): r0 40edec4d r1 41bb67d4 r2 00000002 r3 00003131
I/DEBUG ( 127): r4 00000002 r5 41bb6ae4 r6 41bb67d2 r7 41bb64c0
I/DEBUG ( 127): r8 00000002 r9 41bb6470 sl 00000002 fp 00000002
I/DEBUG ( 127): ip 40edec4d sp 41bb6390 lr 40119a29 pc 40109018 cpsr 00001830
I/DEBUG ( 127): d0 01975f8008000000 d1 ffffffffffffffff
I/DEBUG ( 127): d2 0000001b00000002 d3 0000000000000000
I/DEBUG ( 127): d4 000000004f676753 d5 0000000100000001
I/DEBUG ( 127): d6 002a002700af00af d7 01975f800000ac44
I/DEBUG ( 127): d8 0000000000000000 d9 0000000200000001
I/DEBUG ( 127): d10 0000001000000001 d11 0000000000000000
I/DEBUG ( 127): d12 0000000000000000 d13 0000000000000000
I/DEBUG ( 127): d14 0000000000000000 d15 0000000000000000
I/DEBUG ( 127): d16 3fe0000000000000 d17 417975f800000000
I/DEBUG ( 127): d18 0000000000000000 d19 0000002b000000b0
I/DEBUG ( 127): d20 00000243000001b3 d21 0000000000000047
I/DEBUG ( 127): d22 0000000000000000 d23 000000e4000000dc
I/DEBUG ( 127): d24 000000bf0000002b d25 000000ba000000b5
I/DEBUG ( 127): d26 0000000000002c40 d27 0000002a00000027
I/DEBUG ( 127): d28 bfd4537d57bbab50 d29 3ba3198a2e037073
I/DEBUG ( 127): d30 0000000000002c40 d31 0032002800290029
I/DEBUG ( 127): scr 28000010
I/DEBUG ( 127):
I/DEBUG ( 127): backtrace:
I/DEBUG ( 127): #00 pc 0000e018 /system/lib/libc.so (memcpy+87)
I/DEBUG ( 127): #01 pc 0001ea25 /system/lib/libc.so
I/DEBUG ( 127):
I/DEBUG ( 127): stack:
I/DEBUG ( 127): 41bb6350 0000006d
I/DEBUG ( 127): 41bb6354 000000b5
I/DEBUG ( 127): 41bb6358 0000006e
I/DEBUG ( 127): 41bb635c 0000b000
I/DEBUG ( 127): 41bb6360 0000a000
I/DEBUG ( 127): 41bb6364 4010bfe0 /system/lib/libc.so (__udivdi3+172)
I/DEBUG ( 127): 41bb6368 0000000b
I/DEBUG ( 127): 41bb636c 00000000
I/DEBUG ( 127): 41bb6370 0000000a
I/DEBUG ( 127): 41bb6374 0000000b
I/DEBUG ( 127): 41bb6378 00000000
I/DEBUG ( 127): 41bb637c 0000000a
I/DEBUG ( 127): 41bb6380 00000000
I/DEBUG ( 127): 41bb6384 41bb64b8
I/DEBUG ( 127): 41bb6388 df0027ad
I/DEBUG ( 127): 41bb638c 00000000
I/DEBUG ( 127): #00 41bb6390 ffffffff
I/DEBUG ( 127): ........ ........
I/DEBUG ( 127): #01 41bb6390 ffffffff
I/DEBUG ( 127): 41bb6394 4010a598 /system/lib/libc.so (__gnu_uldivmod_helper+24)
I/DEBUG ( 127): 41bb6398 00000000
I/DEBUG ( 127): 41bb639c 00000002
I/DEBUG ( 127): 41bb63a0 00000002
I/DEBUG ( 127): 41bb63a4 00000000
I/DEBUG ( 127): 41bb63a8 41bb67d2
I/DEBUG ( 127): 41bb63ac 41bb64b8
I/DEBUG ( 127): 41bb63b0 41bb64b0
I/DEBUG ( 127): 41bb63b4 41325585 /system/lib/hw/camera.omap4.so
I/DEBUG ( 127): 41bb63b8 ffffffff
I/DEBUG ( 127): 41bb63bc 4011d12b /system/lib/libc.so (__vfprintf+4730)
I/DEBUG ( 127): 41bb63c0 80000160
I/DEBUG ( 127): 41bb63c4 80000170
I/DEBUG ( 127): 41bb63c8 0000007c
I/DEBUG ( 127): 41bb63cc 00000083

[vishal (vishalbhoj)]

Reverting to AOSP's memcpy the crashes vanishes.

[vishal (vishalbhoj)]

Moving to 12.12

[aaronpoweruser (aaronpoweruser)]

The memcpy in master: https://android-review.googlesource.com/#/c/36645/ fixes this issue and seems to preform better than the current linaro version

[Bernhard Rosenkraenzer (berolinux)]

Fix committed. We're now using the memcpy from master, seems to be about the same speed in my benchmarks.
Still using cortex-strings memcmp and memset, they're faster than the new stuff that landed on master.