wishlist: name of enemy faction

Bug #1074489 reported by vota
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Wargus
Fix Released
Wishlist
cybermind

Bug Description

In original Warcraft at the end of the battle I see enemy faction's name. For example red orcs are referred as Blackrock Clan.

Related branches

Pali (pali)
Changed in wargus:
importance: Undecided → Wishlist
Revision history for this message
Andre Novellino Gouvêa (andre-ng) wrote :

I've written code that implements this feature. Since I'm not an allowed uploader, how do I proceed to share the code?

Revision history for this message
Pali (pali) wrote :

you have launchpad account, so you can push changes to personal branch and create merge requst.

Revision history for this message
Andre Novellino Gouvêa (andre-ng) wrote :

I didn't quite understand how to do that, but the code is available through the mod I made available in the forums:
http://forums.stratagus.com/viewtopic.php?f=7&t=3366&sid=7aec536a6fddb1c2a9ae9fba701b3a3b

The relevant file is guichan.lua, and the only changes to that file are the inclusion of the faction names in the game result screen. The new code is in lines 428-430 and 441-481.

Revision history for this message
cybermind (iddqd-mail) wrote :

Added in rev.1740

Changed in wargus:
status: New → Fix Committed
assignee: nobody → cybermind (iddqd-mail)
cybermind (iddqd-mail)
Changed in wargus:
status: Fix Committed → Fix Released
milestone: none → 2.3
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.