Bib merge should not merge on deleted call numbers

[Steve Callender]

The asset.merge_record_assets DB function does not verify that the call number is deleted before moving items on top of it. This patch will add a check to make sure when checking for identical call numbers, to exclude deleted ones. This way if it exists but is deleted, it will instead just move the source call number over rather than just move the copies onto a deleted call number record.

This was patched against master. Tested in 2.2.2.

Patch located at http://git.evergreen-ils.org/?p=working/Evergreen.git;a=commit;h=f9492325ae92a52171d286eaf651a4508e03c311

Steve

[Ben Shum (bshum)]

Assigning targets, etc. so that we don't lose this.

Will test the fix a bit later.

[Ben Shum (bshum)]

Looks like a good catch Steve, thanks for creating the patch.

I'm testing this but found that the upgrade SQL included with the commit seemed to be an incomplete function.

Creating a revised branch for further testing: user/bshum/do_not_merge_on_deleted_call_numbers

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/bshum/do_not_merge_on_deleted_call_numbers

[Ben Shum (bshum)]

Been using this in our production for the last couple months and periodic tests to see if we're having situations where copies are ending up on deleted volumes has shown zero instances occurring.

I think it's safe to say this change has been useful.