Machine tracker crashes on partial subnet search

[Morten Brekkevold]

When searching for the IP address range string "10.0.0/", Machine Tracker (NAV 3.12) crashes with the following traceback:

Environment:

Request Method: GET
Request URL: http://nav.example.org/machinetracker/ip/?ip_range=10.0.0%2F&active=on&dns=on&days=7
Django Version: 1.2.3
Python Version: 2.6.6
Installed Applications:
['nav.django']
Installed Middleware:
('django.middleware.common.CommonMiddleware',)

Traceback:
File "/usr/lib/pymodules/python2.6/django/core/handlers/base.py" in get_response
  100. response = callback(request, *callback_args, **callback_kwargs)
File "/usr/local/nav/lib/python/nav/web/machinetracker/views.py" in ip_search
  49. return ip_do_search(request)
File "/usr/local/nav/lib/python/nav/web/machinetracker/views.py" in ip_do_search
  69. if form.is_valid():
File "/usr/lib/pymodules/python2.6/django/forms/forms.py" in is_valid
  121. return self.is_bound and not bool(self.errors)
File "/usr/lib/pymodules/python2.6/django/forms/forms.py" in _get_errors
  112. self.full_clean()
File "/usr/lib/pymodules/python2.6/django/forms/forms.py" in full_clean
  267. self._clean_fields()
File "/usr/lib/pymodules/python2.6/django/forms/forms.py" in _clean_fields
  287. value = getattr(self, 'clean_%s' % name)()
File "/usr/local/nav/lib/python/nav/web/machinetracker/forms.py" in clean_ip_range
  50. data = iprange.MachinetrackerIPRange.from_string(data)
File "/usr/local/nav/lib/python/nav/util.py" in from_string
  235. start, stop = cls._parse(rangestring.strip())
File "/usr/local/nav/lib/python/nav/util.py" in _parse
  243. return cls._parse_as_network(rangestring)
File "/usr/local/nav/lib/python/nav/util.py" in _parse_as_network
  283. mask = cls.get_mask_for_network(network)
File "/usr/local/nav/lib/python/nav/web/machinetracker/iprange.py" in get_mask_for_network
  10. prefix_address = prefix.net_address

Exception Type: AttributeError at /machinetracker/ip/
Exception Value: 'NoneType' object has no attribute 'net_address'

[Christian Strand Young (lizter)]

Pull request here: https://bitbucket.org/mbrekkevold/nav-mirror/pull-request/18/machine-tracker-no-longer-crashes-when/diff

[Morten Brekkevold (mbrekkevold)]

fix pushed here: https://nav.uninett.no/hg/stable/rev/a5115f32af13