pcb

G-code exporter should be split out G-code writing

Bug #1074203 reported by Traumflug
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pcb
New
Wishlist
Unassigned

Bug Description

With doubling the feature set over the last year, the G-code exporter's main file, "src/hid/gcode/gcode.c" has become overloaded. It'd be a good idea to split out all the G-code writing into a separate file.

Some 50% of the current exporter handles the distinction between metric/imperial and advanced/basic features. The exporter could hand this over to gcode_writer.c, so it can be stored there and has to be set only once. Then, all geometric stuff could be kept in metric, gcode_writer.c would handle the conversion to inches as required. Possible API:

gcode_writer_fopen()
gcode_writer_fclose()
gcode_writer_set_metric()
gcode_writer_set_inches()
gcode_writer_set_advanced(bool advanced)
gcode_writer_G0()
gcode_writer_isoplunge()
gcode_writer_set_feedrate()
gcode_writer_G1()
gcode_writer_drill()
gcode_writer_comment()
etc ...

Tags: gcode-export
Traumflug (mah-jump-ing)
Changed in pcb:
importance: Undecided → Low
tags: added: gcode-export
Traumflug (mah-jump-ing)
Changed in geda-project:
importance: Undecided → Wishlist
Changed in pcb:
importance: Low → Wishlist
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.