testDates / "make tests" fails on localized Windows systems

[Bogdan Marinov]

On Windows (and probably Linux) machines where the *system* locale is not English, one of the tests in the testDates executable fails, causing it to exit with code 1. As it is a part of the "make tests" target, this also causes executing make for that target to fail. This was discovered on a Windows buildbot machine.

[Bogdan Marinov (daggerstab)]

The problem is in the TestDates::formatting() test, which tests date formatting for different locales. One of the sub-tests compared date strings including day and month names to English values. It calls StelUtils::localeDateString(), assuming that it is affected by QLocale::setDefault().

But localeDateString() uses functions like QDate::shortDayName(), which, at least in Qt 4.8, return according to the *system* locale, not the one set with QLocale::setDefault().
https://bugreports.qt-project.org/browse/QTBUG-27789

[Bogdan Marinov (daggerstab)]

I've commented out the relevant portion of the test:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/5681