logger has problems with errors/warnings containing non-ascii chars

[Jiri Popelka]

Hi,

I think I've found some bugs in logger.

As you can see in this [1] backtrace,
Logger.error(self, message) tries to encode message to "utf-8",
which fails if the message already is in "utf-8" and contains some non-ascii chars.
I think the error() (as well as warn() and fatal()) shouldn't try to encode the message to "utf-8" because Logger.log() does that itself when UnicodeEncodeError occurs.

See also debug(), debug2(), debug3(), info() and note() which do not do that.

[1] https://bugzilla.redhat.com/attachment.cgi?id=633807

[Stanislav (stanislav-redhat-bugs)]

Description of problem:
hplip error

Version-Release number of selected component:
hplip-3.12.10-4.a.fc17

Additional info:
libreport version: 2.0.16
abrt_version: 2.0.16
cmdline: /usr/bin/python /usr/bin/hp-setup -u
kernel: 3.6.2-4.fc17.x86_64

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633804
File: core_backtrace

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633805
File: environ

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633806
File: event_log

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633807
File: backtrace

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633808
File: smolt_data

[Stanislav (stanislav-redhat-bugs)]

Created attachment 633809
File: dso_list

[Jiri (jiri-redhat-bugs)]

The problem seems to be in some "/DevMgmt/FaxConfigDyn.xml" file.
But I haven't been able to find the origin of this file.

[Tim (tim-redhat-bugs)]

Probably comes from the hardware...

[Jiri (jiri-redhat-bugs)]

Stanislav, what's output of the following command (when the printer is on) ?
su -c "lpinfo -l -v"

[Stanislav (stanislav-redhat-bugs)]

[stas@stas-fedora ~]$ su -c "lpinfo -l -v"
Пароль:
WARNING: gnome-keyring:: couldn't connect to: /run/user/stas/keyring-CzEiC7/pkcs11: Нет такого файла или каталога
Device: uri = http
        class = network
        info = Протокол интернет-печати (http)
        make-and-model = Unknown
        device-id =
        location =
Device: uri = ipps
        class = network
        info = Протокол интернет-печати (ipps)
        make-and-model = Unknown
        device-id =
        location =
Device: uri = lpd
        class = network
        info = Хост или принтер LPD/LPR
        make-and-model = Unknown
        device-id =
        location =
Device: uri = https
        class = network
        info = Протокол интернет-печати (https)
        make-and-model = Unknown
        device-id =
        location =
Device: uri = socket
        class = network
        info = AppSocket/HP JetDirect
        make-and-model = Unknown
        device-id =
        location =
Device: uri = ipp
        class = network
        info = Протокол интернет-печати (ipp)
        make-and-model = Unknown
        device-id =
        location =
Device: uri = hp
        class = direct
        info = HP Printer (HPLIP)
        make-and-model = Unknown
        device-id =
        location = ...

[Jiri (jiri-redhat-bugs)]

Hmm, that hasn't shown what I was expecting. Is it a network printer ? If yes, can you show me the output of:
/usr/lib/cups/backend/snmp <ip address or hostname of the printer>

Or do you know the exact model of the printer ?

[Stanislav (stanislav-redhat-bugs)]

Ok, its HP LaserJet Pro 400 color MFP 475 dn
—
[stas@stas-fedora ~]$ /usr/lib/cups/backend/snmp 10.10.77.83
network socket://10.10.77.83 "HP LaserJet 400 colorMFP M475dn" "HP LaserJet 400 colorMFP M475dn" "MFG:Hewlett-Packard;CMD:PJL,PML,PCLXL,URP,PCL,PDF,POSTSCRIPT;MDL:HP LaserJet 400 colorMFP M475dn;CLS:PRINTER;DES:Hewlett-Packard LaserJet 400 colorMFP M475dn;MEM:MEM=169MB;COMMENT:RES=600x8;LEDMDIS:USB#ff#04#01;CID:HPLJPDLV1;" "Location_Not_Printable"
[stas@stas-fedora ~]$

[Tim (tim-redhat-bugs)]

Could you please try running this command? Make sure the printer is on first.

curl --remote-name http://10.10.77.83:8080/DevMgmt/FaxConfigDyn.xml

You should end up with a FaxConfigDyn.xml file. Could you please attach that to this bug report using the "Add an attachment" link on this page (above all the comments)? Thanks.

[Stanislav (stanislav-redhat-bugs)]

Created attachment 635551
curl --remote-name http://10.10.77.83:8080/DevMgmt/FaxConfigDyn.xml

Ok

[Jiri (jiri-redhat-bugs)]

Thanks.
First let's try to get rid of the logger error.

Stanislav, can you edit /usr/share/hplip/base/logger.py and at line 321 replace
txt = "error: %s" % message.encode("utf-8")
with
txt = "error: %s" % message

Then try to reproduce the problem (have you been actually able to reproduce it ?).

[Stanislav (stanislav-redhat-bugs)]

Thanks!
All is ok, printer and scanner and fax is functioning.
Thank you all!

[Jiri (jiri-redhat-bugs)]

I've reported the logger problem upstream as
https://bugs.launchpad.net/hplip/+bug/1073197

[Jiri (jiri-redhat-bugs)]

The problem with XML parsing was reported upstream as
https://bugs.launchpad.net/hplip/+bug/1073228

[Fedora (fedora-redhat-bugs)]

This message is a reminder that Fedora 17 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 17. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as WONTFIX if it remains open with a Fedora
'version' of '17'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version prior to Fedora 17's end of life.

Bug Reporter: Thank you for reporting this issue and we are sorry that
we may not be able to fix it before Fedora 17 is end of life. If you
would still like to see this bug fixed and are able to reproduce it
against a later version of Fedora, you are encouraged change the
'version' to a later Fedora version prior to Fedora 17's end of life.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

[Fedora (fedora-redhat-bugs)]

Fedora 17 changed to end-of-life (EOL) status on 2013-07-30. Fedora 17 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version.

Thank you for reporting this bug and we are sorry it could not be fixed.

[Jiri Popelka (jpopelka)]

The first two hunks of my patch were merged into 3.13.10.

But you still need to fix the fatal() function.

[Amarnath Chitumalla (amarnath-chitumalla)]

Hi Jiri,

Thank you for the patch. We will look into this.

Regards,
Amarnath