Song importer repeatVerse function crashes on no verse order
Bug #1073061 reported by
Phill
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenLP |
Fix Released
|
Medium
|
Phill |
Bug Description
Song importer repeatVerse function crashes on no verse order.
This is because it assumes that the verse order list is has an Item and selects the last item. Where there is no verse order, this causes an index error.
This bug was reported with the "Songs of Fellowship" importer, but in theory could affect all importers. http://
Seen on both Ubuntu 12.04, and confirmed on Windows 7
Related branches
lp:~phill-ridout/openlp/1073061
- Raoul Snyman: Approve
- Tim Bentley: Approve
-
Diff: 17 lines (+4/-3)1 file modifiedopenlp/plugins/songs/lib/songimport.py (+4/-3)
Changed in openlp: | |
status: | In Progress → Fix Committed |
Changed in openlp: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
--- Exception Traceback --- pymodules/ python2. 7/openlp/ core/ui/ wizard. py", line performWizard( ) pymodules/ python2. 7/openlp/ plugins/ songs/forms/ songimportform. py", doImport( ) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ oooimport. py", processOooDocum ent() pymodules/ python2. 7/openlp/ plugins/ songs/lib/ sofimport. py", processSofFile( ) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ sofimport. py", processParagrap h(paragraph) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ sofimport. py", processParagrap hText(text) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ sofimport. py", hText processParagrap hLine(line) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ sofimport. py", hLine repeatVerse( ) pymodules/ python2. 7/openlp/ plugins/ songs/lib/ songimport. py", verseOrderListG enerated[ -1])
Traceback (most recent call last):
File "/usr/lib/
187, in onCurrentIdChanged
self.
File
"/usr/lib/
line 390, in performWizard
importer.
File
"/usr/lib/
line 85, in doImport
self.
File
"/usr/lib/
line 91, in processOooDocument
self.
File
"/usr/lib/
line 106, in processSofFile
self.
File
"/usr/lib/
line 136, in processParagraph
self.
File
"/usr/lib/
line 143, in processParagrap
self.
File
"/usr/lib/
line 180, in processParagrap
self.
File
"/usr/lib/
line 277, in repeatVerse
self.
IndexError: list index out of range