Song importer repeatVerse function crashes on no verse order

Bug #1073061 reported by Phill
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenLP
Fix Released
Medium
Phill

Bug Description

Song importer repeatVerse function crashes on no verse order.
This is because it assumes that the verse order list is has an Item and selects the last item. Where there is no verse order, this causes an index error.

This bug was reported with the "Songs of Fellowship" importer, but in theory could affect all importers. http://support.openlp.org/issues/1631

Seen on both Ubuntu 12.04, and confirmed on Windows 7

Related branches

Revision history for this message
Phill (phill-ridout) wrote :

--- Exception Traceback ---
Traceback (most recent call last):
   File "/usr/lib/pymodules/python2.7/openlp/core/ui/wizard.py", line
187, in onCurrentIdChanged
     self.performWizard()
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/forms/songimportform.py",
line 390, in performWizard
     importer.doImport()
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/oooimport.py",
line 85, in doImport
     self.processOooDocument()
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/sofimport.py",
line 91, in processOooDocument
     self.processSofFile()
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/sofimport.py",
line 106, in processSofFile
     self.processParagraph(paragraph)
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/sofimport.py",
line 136, in processParagraph
     self.processParagraphText(text)
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/sofimport.py",
line 143, in processParagraphText
     self.processParagraphLine(line)
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/sofimport.py",
line 180, in processParagraphLine
     self.repeatVerse()
   File
"/usr/lib/pymodules/python2.7/openlp/plugins/songs/lib/songimport.py",
line 277, in repeatVerse
     self.verseOrderListGenerated[-1])
IndexError: list index out of range

Changed in openlp:
importance: Undecided → Medium
status: New → Confirmed
assignee: nobody → phill (phill-ridout)
status: Confirmed → In Progress
milestone: none → 2.0
tags: added: song song-import support-system
Phill (phill-ridout)
Changed in openlp:
status: In Progress → Fix Committed
Phill (phill-ridout)
Changed in openlp:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.