Missing polygon sections with clearpoly and fullpoly

[Robert Fitzsimons]

Some hid's fail to to render a polygon with attributes clearpoly and fullpoly correctly. Effected hid's gtk/gl, ps, lesstif thin draw modes.

Attached pcb file shows incorrect behaviour. Only the second polygon should be truncated, but the third one is also show truncated, but present in lesstif (normal), png, gerber hid's.

[Robert Fitzsimons (robfitz273k)]

This patch works as expected, though a new common fuction might be more elegant.

[Bert Timmerman (bert-timmerman)]

Hi,

The above patch does not apply clean to git HEAD anymore.

Could you check if the affected HIDs still fail to render properly.

TIA and kind regards,

Bert Timmerman.

[Bert Timmerman (bert-timmerman)]

Hi ,

Digging into this patch and trying to build I get the following warnings and errors:

hid/ps/ps.c: In function ‘do_poly’:
hid/ps/ps.c:1267: warning: no return statement in function returning non-void
hid/ps/ps.c: In function ‘ps_fill_pcb_polygon’:
hid/ps/ps.c:1289: warning: implicit declaration of function ‘NoHolesPolygonDicer’
hid/ps/ps.c: In function ‘ps_ps_graphics_init’:
hid/ps/ps.c:1538: error: ‘ps_draw_pcb_polygon’ undeclared (first use in this function)
hid/ps/ps.c:1538: error: (Each undeclared identifier is reported only once
hid/ps/ps.c:1538: error: for each function it appears in.)

The first two warnings are easy to solve, add a "return 1;" and "#include "polygon.h"".

The third warning regards a function being renamed which leads to a naming inconsistency across HIDs.

I will prepare an additional patch for the above issues, other issues still remain.

Kind regards,

Bert Timmerman.

[Robert Fitzsimons (robfitz273k)]

Hi Bert

It looks like this issue has been fixed by another set of patchs.

hid/common/hidgl.c: Add support for rendering "fullpoly" polygons (e89b30f88aa6e9429d52dd27a12d0ed7f5ccc8e5)
hid/common/draw_helpers.c: Fix thindraw for "fullpoly" polygons (e346f29fd102595ff153e8ef723e3200579abb95)

Robert

[Bert Timmerman (bert-timmerman)]

Hi Robert,

Do you want me to close this bug report as "Fix Committed", "Invalid" or as "Won't Fix" ?

Or does the issue still exist ?

Kind regards,

Bert Timmerman.

[Bert Timmerman (bert-timmerman)]

Hi Robert and all,

As per above thread #6 I'm closing this bug report as "fix committed".

Please file a new bug report if the problem rears it's ugly head.

Kind regards,

Bert Timmerman.

[Bert Timmerman (bert-timmerman)]

Hmm,

These commits have been made in December 2012 ... so have been "fix released:.