Missing mutex != NULL check in i_s_innodb_fill_buffer_pool()

Bug #1072573 reported by Laurynas Biveinis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Invalid
Undecided
Unassigned
5.1
Fix Released
High
Stewart Smith
5.5
Fix Released
High
Stewart Smith
5.6
Invalid
Undecided
Unassigned

Bug Description

Taking this from the MP review as it was submitted too late:

My previous review comment was misleading, sorry about that: buf_page_get_mutex_enter() is better than buf_page_get_mutex() and mutex_enter() combination by preventing a race condition between the calls and not calling mutex_enter on NULL. But it still might return NULL, thus mutex_exit() still has to be conditional in i_s_innodb_fill_buffer_pool().

Related branches

Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

And for 5.1:

i_s_innodb_fill_buffer_pool() still acquires the buffer pool mutex (and has a comment block above it).

Also, mutex_exit() in it should be conditional on block_mutex != NULL.

tags: added: xtradb
tags: added: merge-regression
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2824

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.