Allow samplers and decks beyond 1/2 to sync.
Bug #1072229 reported by
RJ Skerry-Ryan
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Mixxx |
Fix Released
|
Medium
|
RJ Skerry-Ryan | ||
Bug Description
One holdout in our move to n-decks has been the sync code which previously only allowed decks 1 and 2 to sync off of each other.
Related branches
Revision history for this message
| RJ Skerry-Ryan (rryan) wrote | #1 |
| Changed in mixxx: | |
| milestone: | none → 1.11.0 |
| assignee: | nobody → RJ Ryan (rryan) |
| importance: | Undecided → Medium |
| status: | New → In Progress |
| Changed in mixxx: | |
| status: | In Progress → Fix Committed |
| Changed in mixxx: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Swiftb0y (swiftb0y) wrote | #3 |
| lock status: | Metadata changes locked and limited to project staff |
To post a comment you must log in.
My solution for 1.11 is the following:
Samplers and decks now pick which sync target to sync to on the fly. Samplers can only sync to decks currently and decks can't sync to samplers. If you have strong opinions about that please speak up :).
The sync target is:
* The first (in numerical order) deck that is playing (rate > 0) a track that has a detected beatgrid.
* The first (in numerical order) deck that has a track loaded with a detected beatgrid (could be stopped).
So basically, if you sync a sampler and both deck 1 and deck2 are playing a track with a beatgrid then deck 1 will win since numerically it is first. This is all just a workaround until we have master sync in 1.12 but I wanted samplers and decks 3/4 to be able to sync in 1.11.