Crash when saving a new document

[jazzynico]

Reproduced on Windows XP, Inkscape trunk revision 11826, 11804 and 11737 (sorry, I have no older revision on my dev computer).
Not reproduced with 0.48.3.1 and the 0.48.x branch.

I first thought it was due to the recent devlibs changes, but it's apparently older.

Steps:
1. Launch Inkscape.
2. Click on the Save button (or Ctrl+S, or File>Save).
3. Crash with the following message:

---
terminate called after throwing an instance of 'std::logic_error'
  what(): basic_string::_S_construct NULL not valid

Emergency save activated!
Emergency save completed. Inkscape will close now.
---

Saving with File>Save as doesn't triggers the crash, and saving a previously saved document works as expected.

[jazzynico (jazzynico)]

Also reproduced on Ubuntu 11.04, trunk revision 11826.

[su_v (suv-lp)]

On OS X 10.7.4, testing with archived builds:
- Not reproduced with revision <= 11646
- Reproduced with revision >= 11649

Only occurs if there have been no changes to the current new document.

[su_v (suv-lp)]

> #13 sp_file_save_document (parentWindow=..., doc=0x9270f60) at file.cpp:955

Possibly introduced by the changes in r11648:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/11648>

[Alex Valavanis (valavanisalex)]

The offending line in r11826:

Glib::ustring msg = Glib::ustring::format(_("No changes need to be saved."), " ", doc->getURI());

We could do with checking what doc->getURI() is returning!

[jazzynico (jazzynico)]

Patch attached.
Doesn't display the URI in the status bar when saving a new and untouched document.

[jazzynico (jazzynico)]

Fixed in the trunk, revision 11828.

[su_v (suv-lp)]

Probably related:
Bug #1072391 “'Save a copy' crashes if current new document hasn't been saved yet”
<https://bugs.launchpad.net/inkscape/+bug/1072391>