SanISCSIDriver SSH bad cmd processing
Bug #1070489 reported by
Dina Belova
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Cinder |
Fix Released
|
Medium
|
John Griffith | ||
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Dina Belova |
Bug Description
In ssh_execute methon in nova/utils there was a problem with cmd passed to it. From SanISCSIDriver and all other places it is called from cmd is a string. But in ssh_execute method cmd was processed as a list.
Also there is no possibility to change default _execute method that runs command through ssh (though it is overridden in SanISCSIDriver class it is changed to the default one because of root class structure).
Changed in nova: | |
assignee: | nobody → Dina Belova (dbelova) |
Changed in nova: | |
status: | New → In Progress |
Changed in cinder: | |
status: | New → Confirmed |
importance: | Undecided → Medium |
Changed in cinder: | |
assignee: | nobody → John Griffith (john-griffith) |
milestone: | none → grizzly-1 |
Changed in nova: | |
milestone: | none → grizzly-1 |
status: | Fix Committed → Fix Released |
Changed in cinder: | |
status: | Fix Committed → Fix Released |
Changed in nova: | |
milestone: | grizzly-1 → 2013.1 |
Changed in cinder: | |
milestone: | grizzly-1 → 2013.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/14491 github. com/openstack/ nova/commit/ cb9b36c94ba1652 cf60e45ae1d96ba 7bd41e5710
Committed: http://
Submitter: Jenkins
Branch: master
commit cb9b36c94ba1652 cf60e45ae1d96ba 7bd41e5710
Author: Yuriy Taraday <email address hidden>
Date: Tue Aug 28 19:57:54 2012 +0400
SanISCSIDriver SSH execution fixes.
In ssh_execute methon in nova/utils there was a problem with cmd passed to it.
From SanISCSIDriver and all other places it is called from cmd is a string.
But in ssh_execute method cmd was processed as a list. This can make problems
with SanISCSIdriver using.
Also it may be useful to pass execute parameter to this SanISCSIDriver class
to have the opportunity of overriding _execute method (as it is in
VolumeDriver class, that is the root of this class hierarchy). That's why
special checking was added.
Fixes bug 1070489
Change-Id: I73f74f9d095a2c 4316cab88148afe 6a0bde44c5b