pt-stalk --no-stalk and --iterations 1 don't wait for the collect
Bug #1070434 reported by
Daniel Nichter
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Medium
|
Daniel Nichter |
Bug Description
A pt-stalk does:
$trunk/bin/pt-stalk --iterations 1 --dest $dest --variable Uptime --threshold $threshold --cycles 2 --run-time 2 --pid $pid_file -- --defaults-
It means to test --run-time, but it was failing sporadically. Turns out, on _fast_ systems (a rare case where being slow actually makes the test work) pt-stalk runs, triggers, collect subprocess starts, then pt-stalk exists because there's no more iterations. When the tool exists, it kills the collect subprocess, so nothing is collected.
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-stalk-iter-1-bug-1070434
- Daniel Nichter: Approve
-
Diff: 280 lines (+110/-28)2 files modifiedbin/pt-stalk (+43/-0)
t/pt-stalk/pt-stalk.t (+67/-28)
summary: |
- pt-stalk --iterations 1 may not collect + pt-stalk --no-stalk or --iterations 1 may not collect |
Changed in percona-toolkit: | |
status: | In Progress → Fix Committed |
Changed in percona-toolkit: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Correction: it doesn't kill the collect subprocess, it just messes up testing because the tool finishes yet there are still collector subprocesses running.