Unable to remove icon from menuitem

[Vsevolod Velichko]

Impact:
It's not possible to remove icons once added

Test Case:
- download the file from comment #4
- Compile with:
  gcc reproduce-lp1070421.c -o testcase `pkg-config --cflags --libs messaging-menu`
- "Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.

Regression Potential:
Limited, it makes work a case which was broken, if the fix is not correct it would keep not working
---

At the moment if I create some Messaging Menu menuitem with no icon (GIcon *icon = NULL), it is created with no icon, as it is supposed to be.
Then I set some icon with messaging_menu_app_set_source_icon, and later I want to remove it. I call messaging_menu_app_set_source_icon again, providing NULL as pointer to icon, and icon is not removed, but is set to some "icon-not-found" icon (I don't know real name for that icon).
So the only way to remove icon from source is to completely remove it and create again. I suppose that it is a bug.

[Vsevolod Velichko (torkvemada)]

Practically you have to call
  g_menu_item_set_attribute (menuitem, "x-canonical-type", "s", "ImSourceMenuItem");
in case if icon is null.

[Lars Karlitski (larsu)]

Thanks for spotting that bug, Vsevolod. The attached branch fixes it.

[Steve Langasek (vorlon)]

The provided test case is not straightforward for a tester to follow. Please provide a test case that does not rely on knowledge of the indicator APIs.

[Lars Karlitski (larsu)]

Attached a program that reproduces this issue. Compile with:

  cc reproduce-lp1070421.c `pkg-config --cflags --libs messaging-menu`

"Something happened" will appear below the "Empathy" entry in the messaging menu. Without the fix to this bug, an "icon-not-found" icon will be displayed. With the fix, no icon should appear.

[Brian Murray (brian-murray)]

Hello Vsevolod, or anyone else affected,

Accepted indicator-messages into quantal-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/indicator-messages/12.10.5-0ubuntu1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

[Rolf Leggewie (r0lf)]

quantal has seen the end of its life and is no longer receiving any updates. Marking the quantal task for this ticket as "Won't Fix".