[6.1 7.0] account.tax child created before its parent

Bug #1068398 reported by Maxime Chambreuil (http://www.savoirfairelinux.com)
40
This bug affects 8 people
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Confirmed
Low
OpenERP R&D Addons Team 3

Bug Description

Using latest revision of OpenERP 6.1 server, web and addons:
* Create a new database in english without demo data
* Install account_accountant and choose Canada
* Choose the english template and the GST + TVQ sales and purchases taxes
* Check the GST + TVQ for purchase tax, it has one child

In the database, in the table account.tax.template, check the GST + TVQ for purchase tax, it has 2 children

Children taxes are generated from the template before their parent, resulting in an empty parent_id field.

As a workaround, I change the order of the tax in the xml file. The problem moved to another tax (GST + PST for purchases (PE)). See database table content below:

Account.tax.template

             name | id | parent_id
-------------------------------+----+-----------
 GST + PST for sales (MB) | 1 |
 PST for sales - 7% | 2 | 1
 GST for sales - 5% (MB) | 3 | 1
 GST + PST for sales (PE) | 4 |
 GST for sales - 5% (PE) | 5 | 4
 PST for sale - 10% | 6 | 4
 GST + TVQ for sales | 7 |
 GST for sales - 5% (QC) | 8 | 7
 TVQ for sales - 9.5% | 9 | 7
 GST + PST for sales (SK) | 10 |
 GST for sales - 5% (SK) | 11 | 10
 PST for sales - 5% (SK) | 12 | 10
 TVH for sales - 12% | 13 |
 TVH for sales - 13% | 14 |
 TVH for sales - 13.5% | 15 |
 TVH for sales - 15% | 16 |
 GST for sales - 5% | 17 |
 GST + TVQ for purchases | 18 |
 TVQ for purchases - 9.5% | 19 | 18
 GST for purchases - 5% (QC) | 20 | 18
 GST + PST for purchases (MB) | 21 |
 GST for purchases - 5% (MB) | 22 | 21
 PST for purchases - 7% | 23 | 21
 GST + PST for purchases (PE) | 24 |
 GST for purchases - 5% (PE) | 25 | 24 <- parent
 PST for purchases - 10% | 26 | 24
 GST + PST for purchases (SK) | 27 |
 GST for purchases - 5% (SK) | 28 | 27
 PST for purchases - 5% (SK) | 29 | 27
 TVH for purchases - 12% | 30 |
 TVH for purchases - 13% | 31 |
 TVH for purchases - 13.5% | 32 |
 TVH for purchases - 15% | 33 |
 GST for purchases - 5% | 34 |

Account.tax

             name | id | parent_id
------------------------------+----+-----------
 GST for purchases - 5% | 1 |
 GST for purchases - 5% (PE) | 2 | <- no parent
 GST + PST for purchases (SK) | 3 |
 GST for purchases - 5% (SK) | 4 | 3
 TVH for purchases - 12% | 5 |
 TVH for purchases - 13% | 6 |
 TVH for purchases - 13.5% | 7 |
 TVH for purchases - 15% | 8 |
 GST + PST for sales (MB) | 9 |
 GST for sales - 5% (MB) | 10 | 9
 GST + PST for sales (PE) | 11 |
 GST for sales - 5% (PE) | 12 | 11
 GST + TVQ for sales | 13 |
 GST for sales - 5% (QC) | 14 | 13
 GST + PST for sales (SK) | 15 |
 GST for sales - 5% (SK) | 16 | 15
 TVH for sales - 12% | 17 |
 TVH for sales - 13% | 18 |
 TVH for sales - 13.5% | 19 |
 TVH for sales - 15% | 20 |
 GST for sales - 5% | 21 |
 GST + TVQ for purchases | 22 |
 GST for purchases - 5% (QC) | 23 | 22
 GST + PST for purchases (MB) | 24 |
 GST for purchases - 5% (MB) | 25 | 24
 GST + PST for purchases (PE) | 26 |
 PST for sales - 7% | 27 | 9
 TVQ for purchases - 9.5% | 28 | 22
 PST for purchases - 7% | 29 | 24
 PST for sales - 5% (SK) | 30 | 15
 PST for sale - 10% | 31 | 11
 PST for purchases - 10% | 32 | 26
 PST for purchases - 5% (SK) | 33 | 3
 TVQ for sales - 9.5% | 34 | 13

Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello Maxime Chambreuil ,

I have checked it with latest trunk but I did not face problem like your
I found parent account in both object account.tax.template as well as
account tax.

I have attached a text file for your reference.

Thanks and waiting for reply!

Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :
Changed in openobject-addons:
status: New → Incomplete
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

In your example, check the following tax:

GST for purchases - 5% (QC) | 3 |

It should have parent 26.

Changed in openobject-addons:
status: Incomplete → Confirmed
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Any updates?

tags: added: trunk
summary: - [6.1] account.tax child created before its parent
+ [6.1 trunk] account.tax child created before its parent
Revision history for this message
fblauer (fblauer) wrote : Re: [Openerp-canada] [Bug 1068398] [NEW] [6.1 trunk] account.tax child created before its parent
Download full text (4.9 KiB)

Just wanted to remind you that there will be a small change to the TVQ on
Jan 1/2013. Are you aware of the change?

On Fri, Dec 7, 2012 at 8:02 AM, Launchpad Bug Tracker <
<email address hidden>> wrote:

> You have been subscribed to a public bug by Maxime Chambreuil (
> http://www.savoirfairelinux.com) (max3903):
>
> Using latest revision of OpenERP 6.1 server, web and addons:
> * Create a new database in english without demo data
> * Install account_accountant and choose Canada
> * Choose the english template and the GST + TVQ sales and purchases taxes
> * Check the GST + TVQ for purchase tax, it has one child
>
> In the database, in the table account.tax.template, check the GST + TVQ
> for purchase tax, it has 2 children
>
> Children taxes are generated from the template before their parent,
> resulting in an empty parent_id field.
>
> As a workaround, I change the order of the tax in the xml file. The
> problem moved to another tax (GST + PST for purchases (PE)). See
> database table content below:
>
>
> Account.tax.template
>
> name | id | parent_id
> -------------------------------+----+-----------
> GST + PST for sales (MB) | 1 |
> PST for sales - 7% | 2 | 1
> GST for sales - 5% (MB) | 3 | 1
> GST + PST for sales (PE) | 4 |
> GST for sales - 5% (PE) | 5 | 4
> PST for sale - 10% | 6 | 4
> GST + TVQ for sales | 7 |
> GST for sales - 5% (QC) | 8 | 7
> TVQ for sales - 9.5% | 9 | 7
> GST + PST for sales (SK) | 10 |
> GST for sales - 5% (SK) | 11 | 10
> PST for sales - 5% (SK) | 12 | 10
> TVH for sales - 12% | 13 |
> TVH for sales - 13% | 14 |
> TVH for sales - 13.5% | 15 |
> TVH for sales - 15% | 16 |
> GST for sales - 5% | 17 |
> GST + TVQ for purchases | 18 |
> TVQ for purchases - 9.5% | 19 | 18
> GST for purchases - 5% (QC) | 20 | 18
> GST + PST for purchases (MB) | 21 |
> GST for purchases - 5% (MB) | 22 | 21
> PST for purchases - 7% | 23 | 21
> GST + PST for purchases (PE) | 24 |
> GST for purchases - 5% (PE) | 25 | 24 <- parent
> PST for purchases - 10% | 26 | 24
> GST + PST for purchases (SK) | 27 |
> GST for purchases - 5% (SK) | 28 | 27
> PST for purchases - 5% (SK) | 29 | 27
> TVH for purchases - 12% | 30 |
> TVH for purchases - 13% | 31 |
> TVH for purchases - 13.5% | 32 |
> TVH for purchases - 15% | 33 |
> GST for purchases - 5% | 34 |
>
> Account.tax
>
> name | id | parent_id
> ------------------------------+----+-----------
> GST for purchases - 5% | 1 |
> GST for purchases - 5% (PE) | 2 | <- no parent
> GST + PST for purchases (SK) | 3 |
> GST for purchases - 5% (SK) | 4 | 3
> TVH for purchases - 12% | 5 |
> TVH for purchases - 13% | 6 |
> TVH for purchases - 13.5% | 7 |
> TVH for purchases - 15% | 8 |
> GST + PST for sales (MB) | 9 |
> GST for s...

Read more...

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

It's already there:
https://code.launchpad.net/~openerp-canada/openobject-addons/trunk_l10n_ca_hr_payroll/+merge/138595

;)

--
Maxime Chambreuil
1-514-276-5468 #126

----- Mail original -----

Just wanted to remind you that there will be a small change to the TVQ on Jan 1/2013. Are you aware of the change?

On Fri, Dec 7, 2012 at 8:02 AM, Launchpad Bug Tracker < <email address hidden> > wrote:

Revision history for this message
fblauer (fblauer) wrote :

I am talking about sales tax - not payroll :

*Changes to the Quebec Sales Tax on January 1, 2013<http://www.levifca.com/>
*.

Read about

   - QST increases to 9.975% on January 1, 2013
   - QST no longer calculated on GST
   - Changes affecting financial services
   - All federal and provincial departments now pay the tax

On Fri, Dec 7, 2012 at 9:54 AM, Maxime Chambreuil <
<email address hidden>> wrote:

> It's already there:
>
> https://code.launchpad.net/~openerp-canada/openobject-addons/trunk_l10n_ca_hr_payroll/+merge/138595
>
> ;)
> --
> Maxime Chambreuil
> 1-514-276-5468 #126
>
> ------------------------------
> Just wanted to remind you that there will be a small change to the TVQ on
> Jan 1/2013. Are you aware of the change?
>
> On Fri, Dec 7, 2012 at 8:02 AM, Launchpad Bug Tracker <
> <email address hidden>> wrote:
>
>
>
>

--
Fred Blauer CA, CA.IT, CISA
http://openacct.ca
<email address hidden>
514-667-1555

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Regarding the first 2 points, change is here:
http://bazaar.launchpad.net/~openerp-canada/openobject-addons/trunk_l10n_ca_hr_payroll/revision/7851

I don't think that last 2 have any consequences on the module.

Regards,

--
Maxime Chambreuil
1-514-276-5468 #126

----- Mail original -----

I am talking about sales tax - not payroll :

Changes to the Quebec Sales Tax on January 1, 2013 .

Read about

    * QST increases to 9.975% on January 1, 2013
    * QST no longer calculated on GST
    * Changes affecting financial services
    * All federal and provincial departments now pay the tax

On Fri, Dec 7, 2012 at 9:54 AM, Maxime Chambreuil < <email address hidden> > wrote:

Revision history for this message
fblauer (fblauer) wrote :

OK, thanks. (I was confused by the directory named hr_payroll)

On Fri, Dec 7, 2012 at 10:15 AM, Maxime Chambreuil <
<email address hidden>> wrote:

> Regarding the first 2 points, change is here:
>
> http://bazaar.launchpad.net/~openerp-canada/openobject-addons/trunk_l10n_ca_hr_payroll/revision/7851
>
> I don't think that last 2 have any consequences on the module.
>
> Regards,
>
> --
> Maxime Chambreuil
> 1-514-276-5468 #126
>
> ------------------------------
> I am talking about sales tax - not payroll :
>
> *Changes to the Quebec Sales Tax on January 1, 2013<http://www.levifca.com/>
> *.
>
>
>
> Read about
>
> - QST increases to 9.975% on January 1, 2013
> - QST no longer calculated on GST
> - Changes affecting financial services
> - All federal and provincial departments now pay the tax
>
>
> On Fri, Dec 7, 2012 at 9:54 AM, Maxime Chambreuil <
> <email address hidden>> wrote:
>
>
>
>

--
Fred Blauer CA, CA.IT, CISA
http://openacct.ca
<email address hidden>
514-667-1555

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote : Re: [6.1 trunk] account.tax child created before its parent

@jir-openerp Any chance to see this fixed and merged in 6.1 and 7.0 ?

Changed in openobject-addons:
importance: Undecided → Low
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
summary: - [6.1 trunk] account.tax child created before its parent
+ [6.1 7.0] account.tax child created before its parent
Amit Parik (amit-parik)
tags: added: taxes
Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) wrote :

Could it be fixed before v8 release ?

Thanks

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.