proposal for new "pre-cat" EG permission

[Yamil]

(NOTE: this is meant as a wish-list item)

I would like to propose that a new EG permission is created to specifically allow or disallow pre-cat (aka "fast adds"). That way I can give that permission to the full time staff permission group, but not to our student employee group. As of EG 2.3 there is no simple way to disallow pre-cat in EG for a permission group or at the server/system level.

Thanks,
Yamil

[Kathy Lussier (klussier)]

Copying over some comments from Aaronz on https://bugs.launchpad.net/evergreen/+bug/1276328, which was marked as a duplicate of this bug.

Dyrcona on IRC said that "Circ/Circulate.pm and Circ/Noncat.pm is where I'd make changes"

See http://irc.evergreen-ils.org/evergreen/2014-02-04#i_66494 for the conversation on IRC about this issue

[Jason Stephenson (jstephenson)]

Dyrcona in IRC was probably off a bit, since NonCat.pm is something else entirely.

[Aaron Z (aaronz)]

I think that Dyrcona initially thought that I was talking about non-cat circ rather than pre-cat circ.

Aaron Z

[Cesar V (cesardv)]

Here's is a (apparently long awaited!) branch that implements a new permission that can be configured to prevent accidental/unauthorized precat copies by specific staff. RFC:

https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/cesardv/lp1068287_new_precat_perm

[Jane Sandberg (sandbergja)]

This looks excellent, Cesar. Since this is new functionality with a new permission, we will need a brief release note.

[Jane Sandberg (sandbergja)]

I had a chance to try this out more. It works very well for me. Thanks, Cesar.

My only thought: right now, when a user does not have permission to create a pre-cat, there is a note on the pre-cat creation modal saying that they don't have the appropriate permissions. The Precat Checkout button is still enabled; it just doesn't do anything. I think the UI could be a bit better: maybe a separate modal that just says "Barcode "1234567890" was mis-scanned, and you do not have permission to create a precat item", and only show it to those who lack permissions? Thoughts?

BTW, I attached a screenshot of the "You do not have permission to complete this action." modal from this branch.

[Tiffany Little (tslittle)]

What about just disabling (and subsequently greying out) the submit button? The "you can't do this" message is right above the submit button, so that would be enough of a visual indicator for me that I can't continue.

[Michele Morgan (mmorgan)]

Thanks Jane, for providing the screenshot of the pre-cat creation modal. I never like the idea of presenting the user with input boxes that they can fill in, but can't submit.

I like the idea of a separate modal as Jane describes. I also think it would be useful if there was a button on that modal that a supervisor could click so they could provide credentials and complete the precat creation.

[Jason Etheridge (phasefx)]

I've pushed a branch with Cesar's commits squashed into one and an additional commit of my own that does the following:

* relocates the missing permission explanation to the second line at the top of the dialog when it appears
* disables all form elements except the cancel button when the permission is lacking
* allows renewals of pre-cats without checking for the CREATE_PRECAT permission
* adds release notes

top two commits at collab/phasefx/lp1068287
https://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/collab/phasefx/lp1068287

Let me know how that looks!

[Galen Charlton (gmc)]

Pushed to master for inclusion in 3.4. Thanks, Cesar and Jason!