Don't thumbnail network shares
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Files |
Fix Released
|
Medium
|
Jeremy Wootten |
Bug Description
By default pantheon-files thumbnails network shares (such as samba shares). This isn't very good default behaviour, because they need to be thumbnailed again every time they are mounted, and it causes the thumbnailer serverice(tumblerd) to use a lot of memory. Most file managers disable thumbnailing on network shares by default.
ProblemType: Bug
DistroRelease: elementary OS 0.2
Package: pantheon-files 0.1-0~r976+
ProcVersionSign
Uname: Linux 3.2.0-32-generic x86_64
ApportVersion: 2.0.1-0ubuntu13
Architecture: amd64
CrashDB: pantheon_files
Date: Mon Oct 15 16:22:19 2012
InstallationMedia: elementary OS 0.2 "Luna" - Build amd64 LIVE Binary 20121006-14:26
ProcEnviron:
PATH=(custom, no user)
LANG=en_US.UTF-8
SHELL=/bin/bash
SourcePackage: pantheon-files
UpgradeStatus: No upgrade log present (probably fresh install)
Related branches
- Danielle Foré: Approve
- PerfectCarl: Pending requested
-
Diff: 3997 lines (+1190/-604)37 files modifiedlibcore/AbstractSlot.vala (+3/-1)
libcore/gof-callwhenready.vala (+3/-6)
libcore/gof-directory-async.vala (+171/-43)
libcore/gof-file.c (+187/-86)
libcore/gof-file.h (+5/-0)
libcore/marlin-file-operations.c (+35/-12)
libcore/marlin-file-operations.h (+3/-2)
libcore/marlin-trash-monitor.c (+0/-2)
libcore/marlin-undostack-manager.c (+7/-10)
libcore/marlin-undostack-manager.h (+2/-2)
libcore/pantheon-files-core-C.vapi (+18/-13)
libwidgets/LocationBar.vala (+47/-51)
plugins/contractor/plugin.vala (+5/-2)
plugins/network-places/plugin.vala (+0/-26)
plugins/pantheon-files-trash/plugin.vala (+2/-2)
src/Application.vala (+13/-0)
src/BookmarkList.vala (+4/-4)
src/DndHandler.vala (+1/-3)
src/MimeActions.vala (+8/-5)
src/MultiLineEditableLabel.vala (+3/-0)
src/View/AbstractDirectoryView.vala (+325/-144)
src/View/ColumnView.vala (+1/-1)
src/View/DiskRenderer.vala (+8/-3)
src/View/LocationBar.vala (+27/-21)
src/View/OverlayBar.vala (+2/-3)
src/View/PropertiesWindow.vala (+15/-9)
src/View/Resources.vala (+52/-0)
src/View/Sidebar.vala (+51/-44)
src/View/Slot.vala (+16/-17)
src/View/ViewContainer.vala (+101/-57)
src/View/Window.vala (+30/-10)
src/View/directory_view_popup.ui (+10/-0)
src/ZeitgeistManager.vala (+1/-1)
src/gtk+-3.0.vapi (+16/-1)
src/marlin-clipboard-manager.c (+16/-21)
src/marlin-clipboard-manager.h (+1/-1)
src/marlin.vapi (+1/-1)
Changed in pantheon-files: | |
milestone: | none → luna-beta2 |
importance: | Undecided → Low |
status: | New → Confirmed |
tags: |
added: network samba thumbnails tumbler removed: amd64 apport-bug luna third-party-packages |
Changed in pantheon-files: | |
milestone: | luna-beta2 → luna-beta3 |
tags: |
added: networking removed: network |
Changed in pantheon-files: | |
assignee: | nobody → Albert (optimisme) |
milestone: | 0.3-beta1 → luna-rc1 |
status: | Confirmed → Fix Released |
no longer affects: | pantheon-files |
no longer affects: | pantheon-files/trunk |
affects: | elementaryos → pantheon-files |
Changed in pantheon-files: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
milestone: | none → isis-beta1 |
Changed in pantheon-files: | |
milestone: | isis-beta1 → isis-beta2 |
Changed in pantheon-files: | |
milestone: | freya-beta2 → none |
Changed in pantheon-files: | |
assignee: | nobody → Jeremy Wootten (jeremywootten) |
status: | Confirmed → In Progress |
Changed in pantheon-files: | |
milestone: | none → freya-beta2 |
status: | In Progress → Fix Committed |
Changed in pantheon-files: | |
status: | Fix Committed → Won't Fix |
status: | Won't Fix → Fix Released |
Changed in pantheon-files: | |
milestone: | freya-beta2 → 0.2 |
I've also noticed as a nasty side effect of this behavior, it makes it very hard to unmount network shares because tumblerd is constantly keeping the filesystem busy trying to thumbnail videos.