res_partner.credit and debit do not always return correct values

[Ferdinand]

for line in account_move_line_obj.browse(cr, uid, ids) :

line.partner_id.credit is always 0

line.partner_id.debit
          positive value => credit
          negative value => debit

[Amit Parik (amit-parik)]

Hello DR Ferdinand,

Would you please elaborate more on this issue. Please provide a usecase/ steps to reproduce it.

Thanks and waiting for your reply!

[Ferdinand (office-chricar)]

the formula as programmed only works if called as function field from res_partner.

if called "stand alone" it returns wrong values as described

    def _credit_debit_get(self, cr, uid, ids, field_names, arg, context=None):
        query = self.pool.get('account.move.line')._query_get(cr, uid, context=context)
        cr.execute("""SELECT l.partner_id, a.type, SUM(l.debit-l.credit)
                      FROM account_move_line l
                      LEFT JOIN account_account a ON (l.account_id=a.id)
                      WHERE a.type IN ('receivable','payable')
                      AND l.partner_id IN %s
                      AND l.reconcile_id IS NULL
                      AND """ + query + """
                      GROUP BY l.partner_id, a.type
                      """,
                   (tuple(ids),))
        maps = {'receivable':'credit', 'payable':'debit' }
        res = {}
        for id in ids:
            res[id] = {}.fromkeys(field_names, 0)
        for pid,type,val in cr.fetchall():
            if val is None: val=0
            res[pid][maps[type]] = (type=='receivable') and val or -val
        return res

[Ferdinand (office-chricar)]

please wrong values in accounting is not "low" priority

[Josse Colpaert (OpenERP) (jco-openerp)]

Normally this can not be the case as you can see the field credit in the partner form under the Accounting tab (Total Receivable). E.g. when you create customer invoices and validate them (leave open), this field will be positive.

Are you sure to be taking all the account move lines?

[Ferdinand (office-chricar)]

yes

the code is in
http://bazaar.launchpad.net/~c2c/c2c-rd-addons/6.1/files/head:/c2c_account_payment_extension/

./c2c_account_payment_extension/wizard/account_payment_order.py

~line 105

pls look also at
 https://bugs.launchpad.net/openobject-addons/+bug/1066066

[Josse Colpaert (OpenERP) (jco-openerp)]

Dear Ferdinand,

In your domain, the account type is payable. This should be receivable for move lines with credits, which will give you the partners with credit > 0 for sure.

domain = \
            [ ('reconcile_id', '=', False)
            , ('account_id.type', '=', 'payable')
            , ('company_id', '=', company_id)
            , ('partner_id', '!=', False) # must be there in case there are imported lines without partner_id (Deloitte)
            , ('state', '=', 'valid')
            # , ('amount_to_pay', '>', 0) # see later in if statements
            ]

[Ferdinand (office-chricar)]

unfortunately your assumption is not true

on a payable account there are sometimes debit (partial payments and down payments) AND credit moves

[Josse Colpaert (OpenERP) (jco-openerp)]

Indeed, credit is Total Receivable and debit Total Payable.

[Ferdinand (office-chricar)]

can we please agree that this is wrong ?

[Josse Colpaert (OpenERP) (jco-openerp)]

You are right that the name of the field is not logical (credit, debit). The label of the field (string="Total Receivable") however is. We are a little more careful in changing the names of the fields themselves, certainly at a short time before a release and would like to wait the appropriate time for changing it .