_FORTIFY_SOURCE being added syntactically wrong for ppa builds breaking them

[Roger Binns]

I'm the author of apsw - https://code.google.com/p/apsw/ - and have a PPA for builds for various Ubuntu versions at https://launchpad.net/~ubuntu-rogerbinns/+archive/apsw/+packages

This has worked fine for a few years. However builds for Quantal are failing. You can see a failed build log at https://launchpadlibrarian.net/119421086/buildlog_ubuntu-quantal-amd64.python-apsw_3.7.14.1-r1-1ppa1~quantal1_FAILEDTOBUILD.txt.gz - The way I do the ppa build is by running "make ppa" from a source tree.

The cause is because _FORTIFY_SOURCE is being mishandled. Its definition and usage is not coming from my code. I can't tell if the problem is the server side environment having a bug or something involved in making packages for submission is adding it. Perhaps the Python stuff on 12.04 (where I do the ppa submissions) is putting in gunk that breaks 12.10?

Attached is a .build file from the client machine. It contains the following line which is not my doing

dpkg-buildpackage: export CPPFLAGS from dpkg-buildflags (origin: vendor): -D_FORTIFY_SOURCE=2

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: python-dev 2.7.3-0ubuntu2
ProcVersionSignature: Ubuntu 3.2.0-31.50-generic 3.2.28
Uname: Linux 3.2.0-31-generic x86_64
NonfreeKernelModules: nvidia
ApportVersion: 2.0.1-0ubuntu13
Architecture: amd64
Date: Wed Oct 10 15:39:41 2012
SourcePackage: python-defaults
UpgradeStatus: No upgrade log present (probably fresh install)

[Matthias Klose (doko)]

it looks like the Ubuntu package for raring did build. I do see that you use another packaging debian directory. Maybe you could update the packaging, and see if it does build? And please drop using dh_pycentral ...

[Roger Binns (ubuntu-rogerbinns)]

I am talking about my PPA builds, *not* the Ubuntu supplied package which is always dreadfully out of date. When I use pbuilder locally everything builds fine. The same dsc when running on Ubuntu's PPA build mechanism is adding D_FORTIFY_SOURCE=2 the wrong way.

dh_pycentral is used because the same package is built in ppas for multiple Ubuntu versions going back to 10.04. dh_pycentral does work for every version other than Quantal PPA build (but local is fine). If there is a different helper that is compatible then I'll use it, but you need to tell me which one it is.

[Scott Kitterman (kitterman)]

Those are the standard distribution build flags now. If you don't want them
added, you need to override them in debian/rules.

[Roger Binns (ubuntu-rogerbinns)]

@Scott: the problem is not the addition of the flags. I have no problem with them being added, being different for PPAs or anything like that.

The problem is that the flags are added in an *invalid way*. See a more detailed recent/build log at https://launchpadlibrarian.net/128659634/buildlog_ubuntu-quantal-amd64.python-apsw_3.7.15.2-r1-1ppa1~quantal1_FAILEDTOBUILD.txt.gz

ie the flags are supposed to be added like this: [ ('_FORTIFY_SOURCE', '2'), ('FOO', 'BAR') ] which translates into
#define _FORTIFY_SOURCE 2
#define FOO BAR

Instead this is being supplied: [ '_FORTIFY_SOURCE', '2' ] which translates into
#define _FORTIFY_SOURCE
#define 2

The PPA system is messing up the *syntax* of how it adds the flags, and then that causes the builds to fail.

[Roger Binns (ubuntu-rogerbinns)]

Building for raring ppa is also broken for the same reason.

[Matthias Klose (doko)]

closing this. sorry, no time to inverstigate this, and it's apparently not an issue in the archive