C++ classes used in walktrap community detection are in global namespace

[Christopher Lu]

The walktrap community detection algorithm uses classes that are in the global namespace. They should be in the igraph namespace, to avoid conflicts with users who wish to incorporate igraph into C++ projects. The 'Graph' class should also be renamed to not conflict with igraph::Graph as used by bliss.

A patch containing these changes is attached (tested on Ubuntu 10.04, igraph 0.6).

[Tamás Nepusz (ntamas)]

Thanks a lot for the patch! If Gabor has no objections, I will merge it in a few days or so.

[Gábor Csárdi (gabor.csardi)]

Thanks for the patch! I would actually prefer to leave the original walktrap code as intact as possible, because it is easier to update third party code, if they would come up with a new version. (This is probably not too important for walktrap because I already changes the code, and they most probably won't have a new version, but still.)

So I would create a walktrap namespace inside the igraph namespace, or put the whole thing in the igraph_walktrap namespace., instead of renaming the classes. Probably the first is better C++ practice.

Thanks again!

[Tamás Nepusz (ntamas)]

Merged to trunk in #3002 and to 0.6-main in #2966. (The walktrap classes are not part of the public API so we can do this).

[Gábor Csárdi (gabor.csardi)]

The development of igraph has moved to github, so please do not comment on this bug here. You are of course welcome to comment on github, here:
https://github.com/igraph/igraph/issues/239