[DecoratedWindow] Closing window with the X also selects what's under

Bug #1062967 reported by Damien
82
This bug affects 14 people
Affects Status Importance Assigned to Milestone
Granite
Fix Released
Medium
Marcus Lundgren

Bug Description

But only if what's under is the left sidebar apparently.

How to reproduce: right click on a file, properties.
move the window so that the X closing button is over a folder in the left panel (personal files, peripherals).
Click on that X to close the properties window
admire the folder being selected and opened.

Related branches

Damien (youpla-b)
description: updated
affects: elementaryos → pantheon-files
Revision history for this message
Victor Martinez (victored) wrote :

Granite's DecoratedWindow should not propagate the event. This also affects noise and all the applications using granite's LightWindow.

affects: pantheon-files → granite
Changed in granite:
status: New → Confirmed
importance: Undecided → Medium
Changed in granite:
assignee: nobody → Victor Eduardo (victored)
milestone: none → 0.1.1
status: Confirmed → In Progress
summary: - Closing folder properties with the X also selects what's under
+ [DecoratedWindow] Closing window with the X also selects what's under
Changed in granite:
status: In Progress → Fix Committed
Changed in granite:
status: Fix Committed → Fix Released
Revision history for this message
Damien (youpla-b) wrote :

"Fix released" as in, the end user should not have this bug anymore? Because after the latest updates I still have it.

Cody Garver (codygarver)
Changed in granite:
status: Fix Released → Confirmed
assignee: Victor Eduardo (victored) → nobody
milestone: 0.1.1 → luna-beta2
Revision history for this message
Julián Unrrein (junrrein) wrote :

I still have this bug. It's especially a problem in pantheon-files, since the properties dialog tends to open in a position such that the X button is located over the sidebar.

Revision history for this message
Damien (youpla-b) wrote :

I saw this comment in one of the other bug reports and I noticed it too:
Moving the pointer somewhere else before releasing the click makes the shortcut not open.

closing the decorated window is on click-press
opening a shortcut is on click-release
shortcuts are on select on hover
Therefore if both events are on the same location, both will happen.

Making closing on click-release should solve this.
Or copy the code from files/folders, as even with autoselect on this doesn't happen.

Revision history for this message
Erasmo Marín (erasmo-marin) wrote :

Agree with Damien, I said the same thing in a duplicated bug of this. The problem is that the widget is using the button press event instead of the button release event, so an easy solution would be to change that.

Changed in granite:
assignee: nobody → Marcus Lundgren (marcus-lundgren)
status: Confirmed → In Progress
Cody Garver (codygarver)
Changed in granite:
status: In Progress → Fix Released
Revision history for this message
Damien (youpla-b) wrote :

I confirm this bug is solved for me.

Revision history for this message
Siniša Perović (sinisa-p) wrote :

Solved for me! Thanx guys.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.