No confirmation/error if you are already a member

Bug #1062849 reported by Shloka Kini
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Postorius
Fix Released
Medium
Unassigned

Bug Description

for Systers - GHC 2012 Open Source Day

Revision history for this message
Terri (terriko) wrote :

Related to this bug https://bugs.launchpad.net/postorius/+bug/1004052 which points out that we're missing confirmations in a lot of places.

In many circumstances, you don't want a message because this could be used to figure out who's on the list, but if we're using browserid then they have already confirmed that they own this email address so it should be safe to specify if they were already subscribed.

Changed in postorius:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
mahendra (mahendra007-s) wrote :

added:
  src/postorius/templates/postorius/more_info_display.html
modified:
  src/postorius/templates/postorius/lists/settings.html
  src/postorius/urls.py
  src/postorius/views/user.py

Added template (src/postorius/templates/postorius/more_info_display.html) to display more info about field of a particular form.

NOTE:-
As I found that "more info" links are currently for list settings form so in the function added "more_info_tab" in user.py checks only for list settings form.More form checks can be added by using if and elseif as we add more info links to other forms.

Regards
Mahendra

Revision history for this message
Terri (terriko) wrote :

This patch is brilliant, thank you mahendra! I've done the merge locally and I'll push it up to the trunk shortly.

Also, I can't remember if you're at all interested in Google Summer of Code, but I just want to say that we're super impressed with your patch and would love to have you sign up!

Changed in postorius:
status: Triaged → Fix Committed
Revision history for this message
Terri (terriko) wrote :

Annnd... I just realized that this code got associated with the wrong bug. No matter but I will re-open this bug since it's not exactly fixed by this patch.

Changed in postorius:
status: Fix Committed → Triaged
status: Triaged → Fix Committed
Revision history for this message
Terri (terriko) wrote :

This bug is actually fixed, just not by this patch, re-closing. apparently after a week of PyCon I am entirely too easily confused.

Revision history for this message
mahendra (mahendra007-s) wrote :

Sorry, for posting it here by mistake. Commented on right place with associated bug#1090817 at https://bugs.launchpad.net/postorius/+bug/1090817/comments/1
Regarding this bug, I can't reproduce this bug at-least for now, hopefully fixed by some other patch as you said. So, it shows error like "Already a member" or something like that when re-adding the member.

Changed in postorius:
milestone: none → 1.0.0a2
Changed in postorius:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.