User Settings should have defaults
Bug #1060454 reported by
Thomas Berezansky
This bug affects 3 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Evergreen |
Fix Released
|
Wishlist
|
Unassigned |
Bug Description
At registration, anyway, it would be beneficial to be able to specify default values for user settings. This would allow default A/T settings and explicit defaults for other settings (like, say, hold notifications, where you might want to change the default of 'phone:email' to just 'email' or add in 'sms').
The branch below attempts to do so for anything that shows up in the registration form.
Changed in evergreen: | |
status: | New → Confirmed |
importance: | Undecided → Wishlist |
Changed in evergreen: | |
milestone: | none → 2.4.0-rc |
Changed in evergreen: | |
milestone: | 2.4.0-rc → 2.5.0-alpha |
Changed in evergreen: | |
milestone: | 2.5.0-m1 → 2.5.0-m2 |
Changed in evergreen: | |
assignee: | nobody → Jason Etheridge (phasefx) |
Changed in evergreen: | |
status: | Confirmed → Fix Committed |
Changed in evergreen: | |
assignee: | Jason Etheridge (phasefx) → nobody |
Changed in evergreen: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Here's some notes from Aaron about this issue.
12:53 <AaronZ-PLS> edoceo: Playign with this now and if the patron email address is missing, Evergreen will create the entire email but sendmail will not send it
to put the address inside of the percent sign/square brackets like the default variables are
mark them as invalid so that the system doesnt have to process them
12:56 <AaronZ-PLS> Also note that if you want to use a fixed email address for the "from" field (ie: <email address hidden>), you only have to put in the email address as text. You dont need
12:58 <AaronZ-PLS> A worthwhile addition as a new validator might be to detect invalid email addresses (ie: missing the @ sign, no email address at all, etc) and skip those addresses or
I've also tested this code in my Evergreen working environment and it seems to behave as expected.