html5 validation issues
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Pluck CMS |
Fix Committed
|
Low
|
Unassigned |
Bug Description
I am trying to make a "valid" html5 template.
I found the following issues:
1.
The action attribute of the form element in the module contactform cannot be empty for html5.
It should point to itself.
Possible fixes in contactform.
<form method="post" action="<?php echo htmlspecialchar
or
<form method="post" action="#" id="contactform">
or
reconstruct the current URI with SITE_URL and ...
2.
The metadata generated in functions.site.php
The meta name="language" is invalid for html5 and is redundant, as the attribute lang (and xml:lang) for the html tag serve this purpose. This is also unnecessary for xhtml and one can argue that by now this attribute is obsolete, as (all major) search engines respect the attributes in the html tag.
The meta name="title" is invalid for html5 and is redundant, as the title tag serves this purpose. Similar argument as above.
see http://
If the two meta tags are dropped and the contactform fixed, pages can easily be made html5 "valid".
Haven't checked albums or blog module though.
Related branches
- Anders G. Jørgensen: Approve
-
Diff: 72 lines (+14/-10)3 files modifieddata/inc/editpage.php (+8/-7)
data/inc/functions.admin.php (+4/-1)
data/inc/functions.all.php (+2/-2)
Changed in pluck-cms: | |
importance: | Undecided → Low |
fixed in lp:~uranium235/pluck-cms/pluck-cms