TextEntry::SetPasswordMode does the opposite of what is expected

[Manuel de la Peña]

The following code is an example of the bug:

password_entry_ = new nux::TextEntry();
password_entry_->SetPasswordMode(true);
const char password_char = '*';
password_entry_->text_entry()->SetPasswordChar(&password_char);

The above code should create a text entry that when it receives a key input from the user shows * instead of the actual chars. Unfortunately it is not the case. The main reason resides in the fact that the SetPasswordMode function is defined as:

void SetPasswordMode(bool visible)
{
  SetVisibility(visible);
}

When it should be:

void SetPasswordMode(bool visible)
{
  SetVisibility(!visible);
}

This means that atm the code has to be:

password_entry_->SetPasswordMode(false);

which as you will agree does not make sense.