Warnings when compiling with -Wextra
Bug #1056633 reported by
Michi Henning
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Nux |
Fix Released
|
High
|
Michi Henning | ||
| nux (Ubuntu) |
Fix Released
|
High
|
Michi Henning | ||
Bug Description
When turning on -Wextra, compiling the code produces around 11000 warnings about unused parameters.
Related branches
lp:~michihenning/nux/1056633
- Daniel d'Andrada (community): Approve
- Michi Henning (community): Approve
-
Diff: 6174 lines (+942/-956)159 files modifiedNux/AbstractButton.cpp (+5/-5)
Nux/AbstractCheckedButton.cpp (+1/-1)
Nux/AbstractComboBox.cpp (+13/-13)
Nux/ActionItem.cpp (+1/-1)
Nux/AnimatedTextureArea.cpp (+6/-6)
Nux/Area.cpp (+8/-8)
Nux/Area.h (+2/-2)
Nux/BaseWindow.cpp (+5/-5)
Nux/BasicView.cpp (+1/-1)
Nux/Button.cpp (+2/-2)
Nux/Canvas.cpp (+2/-2)
Nux/CheckBox.cpp (+2/-2)
Nux/ClientArea.cpp (+24/-24)
Nux/ColorEditor.cpp (+10/-10)
Nux/ColorPickerDialog.cpp (+1/-1)
Nux/ColorPreview.cpp (+4/-4)
Nux/Coverflow.cpp (+32/-32)
Nux/CoverflowItem.h (+1/-1)
Nux/EditTextBox.cpp (+11/-11)
Nux/FileSelector.cpp (+18/-18)
Nux/FloatingWindow.cpp (+8/-8)
Nux/GeisAdapter.cpp (+4/-2)
Nux/GroupBox.cpp (+4/-4)
Nux/GroupBox2.cpp (+3/-3)
Nux/HLayout.cpp (+1/-1)
Nux/HScrollBar.cpp (+19/-19)
Nux/HScrollBar.h (+2/-2)
Nux/HSplitter.cpp (+5/-5)
Nux/InputArea.cpp (+5/-5)
Nux/InputArea.h (+2/-2)
Nux/InputMethodIBus.cpp (+11/-19)
Nux/KeyboardHandler.cpp (+6/-6)
Nux/LayeredLayout.cpp (+10/-10)
Nux/Layout.cpp (+5/-5)
Nux/Layout.h (+6/-6)
Nux/LinearLayout.cpp (+1/-1)
Nux/MainLoopGLib.cpp (+9/-6)
Nux/MenuBar.cpp (+10/-10)
Nux/MenuPage.cpp (+13/-13)
Nux/MenuPage.h (+4/-4)
Nux/MouseAreaCtrl.cpp (+5/-5)
Nux/NumericValuator.cpp (+2/-2)
Nux/Nux.cpp (+3/-3)
Nux/Painter.cpp (+14/-14)
Nux/Panel.cpp (+1/-1)
Nux/ProgramFramework/ProgramTemplate.cpp (+2/-2)
Nux/ProgramFramework/TestTextEntry.cpp (+11/-11)
Nux/ProgramFramework/TestView.cpp (+11/-11)
Nux/RGBValuator.cpp (+164/-164)
Nux/RadioButton.cpp (+2/-2)
Nux/RangeValue.cpp (+6/-6)
Nux/RangeValueInteger.cpp (+6/-6)
Nux/ScrollView.cpp (+5/-5)
Nux/SpinBox.cpp (+2/-2)
Nux/SpinBoxDouble.cpp (+2/-2)
Nux/SpinBox_Logic.cpp (+46/-46)
Nux/StaticText.cpp (+2/-2)
Nux/StaticTextBox.cpp (+3/-3)
Nux/SystemThread.cpp (+3/-3)
Nux/TabView.cpp (+25/-25)
Nux/TextEntry.cpp (+8/-8)
Nux/TextLoader.cpp (+2/-2)
Nux/TextureArea.cpp (+17/-17)
Nux/Theme.cpp (+7/-7)
Nux/Timeline.cpp (+1/-1)
Nux/ToolButton.cpp (+34/-34)
Nux/VLayout.cpp (+1/-1)
Nux/VScrollBar.cpp (+19/-19)
Nux/VScrollBar.h (+2/-2)
Nux/VSplitter.cpp (+5/-5)
Nux/Validator.h (+1/-1)
Nux/View.cpp (+14/-14)
Nux/View.h (+1/-1)
Nux/WindowCompositor.cpp (+4/-4)
Nux/WindowThread.cpp (+6/-6)
NuxCore/FileManager/NFileManagerGNU.cpp (+6/-6)
NuxCore/FileManager/NFileManagerGNU.h (+5/-5)
NuxCore/FileManager/NFileManagerGeneric.cpp (+3/-5)
NuxCore/FileManager/NFileManagerGeneric.h (+1/-1)
NuxCore/FileManager/NSerializer.h (+2/-2)
NuxCore/Memory.cpp (+2/-2)
NuxCore/NuxCore.cpp (+2/-2)
NuxCore/NuxCore.h (+3/-1)
NuxCore/Object.cpp (+3/-0)
NuxCore/ObjectPtr.h (+2/-2)
NuxCore/OutputDevice.cpp (+2/-2)
NuxCore/OutputDevice.h (+1/-1)
NuxCore/Parsing.cpp (+1/-1)
NuxCore/Platform.cpp (+1/-1)
NuxCore/Property-inl.h (+2/-2)
NuxCore/TextString.h (+4/-3)
NuxCore/ThreadGNU.cpp (+2/-2)
NuxCore/ThreadGNU.h (+1/-1)
NuxGraphics/CairoGraphics.cpp (+1/-1)
NuxGraphics/FontTexture.cpp (+1/-1)
NuxGraphics/GLError.cpp (+1/-1)
NuxGraphics/GLPBuffer.cpp (+1/-1)
NuxGraphics/GLResource.cpp (+2/-2)
NuxGraphics/GLResourceManager.h (+3/-3)
NuxGraphics/GLSh_ColorPicker.cpp (+1/-1)
NuxGraphics/GLSh_DrawFunction.cpp (+1/-1)
NuxGraphics/GLSh_Fill.cpp (+1/-1)
NuxGraphics/GLShaderParameter.h (+1/-1)
NuxGraphics/GLTemplatePrimitiveBuffer.cpp (+1/-3)
NuxGraphics/GLTextureResourceManager.cpp (+9/-9)
NuxGraphics/GpuDevice.cpp (+1/-1)
NuxGraphics/GpuDeviceTexture.cpp (+5/-4)
NuxGraphics/GpuDeviceVertex.cpp (+10/-10)
NuxGraphics/GraphicsDisplayX11.cpp (+1/-1)
NuxGraphics/GraphicsEngine.cpp (+4/-4)
NuxGraphics/IOpenGLAnimatedTexture.h (+1/-1)
NuxGraphics/IOpenGLBaseTexture.cpp (+13/-13)
NuxGraphics/IOpenGLCubeTexture.cpp (+1/-1)
NuxGraphics/IOpenGLQuery.cpp (+2/-2)
NuxGraphics/IOpenGLRectangleTexture.cpp (+1/-1)
NuxGraphics/IOpenGLTexture2D.cpp (+1/-1)
NuxGraphics/IOpenGLVertexDeclaration.cpp (+1/-1)
NuxGraphics/ImageSurface.cpp (+6/-6)
NuxGraphics/ImageSurface.h (+4/-4)
NuxGraphics/RenderingPipeAsm.cpp (+7/-7)
NuxGraphics/RenderingPipeGLSL.cpp (+8/-8)
configure.ac (+2/-2)
examples/coverflow.cpp (+1/-1)
examples/gestures.cpp (+3/-3)
examples/line-separator.cpp (+1/-1)
examples/line-separator.h (+1/-1)
examples/shortcut-keys.cpp (+2/-2)
examples/text_entry_focus.cpp (+2/-2)
gputests/arb_programs_limits.cpp (+1/-1)
gputests/framebufferobject.cpp (+1/-1)
gputests/quad_2texmod.cpp (+1/-1)
gputests/texture_blur.cpp (+1/-1)
gputests/texture_copy_blur.cpp (+1/-1)
gputests/texture_data.cpp (+1/-1)
gputests/texture_power_of_2.cpp (+1/-1)
tests/geis_mock.cpp (+17/-17)
tests/gtest-nux-area.cpp (+1/-1)
tests/gtest-nux-cairo-wrapper.cpp (+1/-1)
tests/gtest-nux-gesturebroker.cpp (+2/-2)
tests/gtest-nux-windowcompositor.cpp (+4/-4)
tests/gtest-nuxcore-object.cpp (+1/-1)
tests/nux_automated_test_framework.cpp (+1/-1)
tests/test-scrollview.cpp (+2/-2)
tests/test_empty_window.cpp (+2/-2)
tests/test_graphics_display.cpp (+2/-2)
tests/xtest-button.cpp (+3/-4)
tests/xtest-focus-on-mouse-down.cpp (+3/-4)
tests/xtest-focus-on-mouse-enter.cpp (+3/-4)
tests/xtest-hgrid-key-navigation.cpp (+3/-4)
tests/xtest-hlayout-key-navigation.cpp (+3/-4)
tests/xtest-keynav-directions.cpp (+3/-4)
tests/xtest-mouse-buttons.cpp (+3/-4)
tests/xtest-mouse-events.cpp (+3/-4)
tests/xtest-scrollbar.cpp (+3/-4)
tests/xtest-text-entry-compositionkeys.cpp (+3/-4)
tests/xtest-text-entry-deadkeys.cpp (+3/-4)
tests/xtest-text-entry-logic.cpp (+3/-4)
tests/xtest-text-entry.cpp (+4/-5)
tests/xtest-vlayout-key-navigation.cpp (+4/-5)
| Changed in nux: | |
| milestone: | none → 4.0 |
| importance: | Undecided → High |
| assignee: | nobody → Michi Henning (michihenning) |
| status: | New → In Progress |
Revision history for this message
| Michi Henning (michihenning) wrote | #1 |
| Changed in nux: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Stephen M. Webb (bregma) wrote | #2 |
| Changed in nux: | |
| status: | Fix Committed → Fix Released |
| Changed in nux (Ubuntu): | |
| status: | New → Fix Released |
| assignee: | nobody → Michi Henning (michihenning) |
| importance: | Undecided → High |
To post a comment you must log in.
-Wextra procudes a lot of useful warnings, as I found out when I turned it on and filtered out the unused parameter warnings (see bug #1032313).
In addition, I want to know when I'm not using a parameter so I can make a conscious decision about whether I just made a mistake or whether I indeed don't need the parameter. If so, it is trivial to remove the warning by commenting out the identifier. (I normally leave the identifier in place for documentation, rather than deleting it.)