glance-scrubber not scrubbing with swift backend

Bug #1056127 reported by Paul Bourke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
High
Paul Bourke
Folsom
New
Undecided
Unassigned

Bug Description

It seems the fix for bug #1052537 was incomplete, as I have found glance-scrubber is still not completing it's work when run against a swift backend.

With more investigation it seems the proper way to execute a starmap/imap is to consume it within a loop. This can be replicated by taking the simple web crawler example from http://eventlet.net/doc/ and removing the for loop from around the imap call.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/13627

Changed in glance:
assignee: nobody → Paul Bourke (pauldbourke)
status: New → In Progress
Brian Waldon (bcwaldon)
Changed in glance:
importance: Undecided → High
milestone: none → grizzly-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/13627
Committed: http://github.com/openstack/glance/commit/d032ad5d412d4bb77f9bfb7c7fca424399f80c42
Submitter: Jenkins
Branch: master

commit d032ad5d412d4bb77f9bfb7c7fca424399f80c42
Author: Paul Bourke <email address hidden>
Date: Tue Sep 25 12:43:35 2012 +0100

    Fix scrubber not scrubbing with swift backend

    It seems the fix for bug #1052537 was incomplete, as I have found
    glance-scrubber is still not completing it's work when run against a
    swift backend.

    With more investigation it seems the proper way to execute a
    starmap/imap is to consume it within a loop. This can be replicated by
    taking the simple web crawler example from http://eventlet.net/doc/ and
    removing the for loop from around the imap call.

    Also:
    * Add new test to check this failure against Swift (respects the
      GLANCE_TEST_SWIFT_CONF environment variable).

    Fixes bug 1056127

    Change-Id: I2d289666b99f3216a6d424dbbacbd2d10899263d

Changed in glance:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
Brian Waldon (bcwaldon) wrote :

This probably needs to be backported to stable/folsom

Changed in glance:
milestone: grizzly-1 → 2012.2.4
milestone: 2012.2.4 → none
tags: added: folsom-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.