Conflicting declaration of g_pPrimaryContainer

[Michael Tautschnig]

Here's another result from our build with link-time type checking: there are conflicting declarations of the variable g_pPrimaryContainer as follows:

./src/gldit/cairo-dock-container.c:CairoContainer *g_pPrimaryContainer = NULL;
./src/gldit/cairo-dock-manager.c:extern CairoDock *g_pPrimaryContainer;

All other code properly declares g_pPrimaryContainer as extern CairoContainer it seems, just cairo-dock-manager is off. Likely this is a cosmetic issue at present only as cairo-dock-manager.c only performs a comparison to NULL, but future more elaborate use of the variable will lead to undefined behaviour.

Best,
Michael

[Matthieu Baerts (matttbe)]

Thank you for this bug report and all details!

This bug should be fixed with the rev 1229¹

Matth

[1] https://bazaar.launchpad.net/~cairo-dock-team/cairo-dock-core/cairo-dock/revision/1229