Ratings in playlist don't persist

Bug #1054637 reported by Dr. John
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Exaile
Fix Released
High
Dustin Spicuzza

Bug Description

I'm using Exaile 0.3.3.0-dev with Ubuntu 10.04.

Song ratings don't seem to persist between application launches.

If I rate a song in a playlist, then close the playlist and reopen it,
the rating is maintained.
But if I close Exaile and restart it, when I open the playlist the
ratings are gone.

Related branches

Revision history for this message
Dustin Spicuzza (dustin-virtualroadside) wrote :

Odd. When you run Exaile from a terminal, are there any tracebacks displayed?

Revision history for this message
Dr. John (john-roshi) wrote :

When run in a terminal, several warnings appear:

/usr/local/lib/exaile/xl/main.py:271: Warning: unable to set property `rating' of type `gint' from value of type `gchararray'
  self.gui.main.window.show_all()
INFO : Playing file:///media/MultiMedia/Music/Aria.mp3
/usr/local/lib/exaile/xlgui/__init__.py:53: Warning: unable to set property `rating' of type `gint' from value of type `gchararray'
  gtk.main()
/usr/local/lib/exaile/xlgui/widgets/playlist.py:823: Warning: unable to set property `rating' of type `gint' from value of type `gchararray'
  self.scroll_to_cell(path)
/usr/local/lib/exaile/xlgui/widgets/playlist.py:889: Warning: unable to set property `rating' of type `gint' from value of type `gchararray'
  return gtk.TreeView.do_button_press_event(self, e)

Revision history for this message
Dustin Spicuzza (dustin-virtualroadside) wrote :

Looking at my own install, it does appear that ratings do not persist. However, I don't get any error messages. Will look at this further next week.

Changed in exaile:
importance: Undecided → Medium
milestone: none → 3.4.0
status: New → Confirmed
Revision history for this message
Dustin Spicuzza (dustin-virtualroadside) wrote :

I decided to look at this tonight. This actually is just a symptom of a bigger problem -- and I know why this is occurring, but I don't have a good fix for it yet.

What's happening is *something* is creating the track objects before the Track Database is loaded. Because this is happening, the rating isn't loaded into the track. In particular, I've found that if a track is in the queue, it will tend to be created before the collection is loaded.

As a workaround, you can disable the splash screen (Preferences -> Appearance -> Show splash screen on startup) and ratings may work properly. Alternatively, don't use the queue. Disabling various plugins may help as well.

Changed in exaile:
importance: Medium → High
Changed in exaile:
milestone: 3.4.0 → 3.3.1
Revision history for this message
Dustin Spicuzza (dustin-virtualroadside) wrote :

Fixed in trunk in r4346 , and in 3.3.1 in r4313

Someone else should review this fix to make sure I didn't mess anything up. However, I believe this should not affect anything adversely.

Changed in exaile:
assignee: nobody → Dustin Spicuzza (dustin-virtualroadside)
status: Confirmed → Fix Committed
Changed in exaile:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.