Inconsistent typing of variable dirmode

[Michael Tautschnig]

Hi,

While compiling your package using our research compiler infrastructure it became apparent that the variable "dirmode" in structural_properties.c, function igraph_diameter, wrongly is of type igraph_integer_t, when it should be of type igraph_neimode_t instead.

As igraph_integer_t is a typedef name for double, the conversion to and from an enum may have surprising results.

Best,
Michael

[Tamás Nepusz (ntamas)]

Thanks - I cannot imagine how this could have slipped through the cracks such a long time ago (the functions involved have been added to igraph pretty early). I will fix this ASAP.

Note that several other functions are also affected in structural_properties.c (search for "dirmode" to find the remaining occurrences), but this is not a problem from igraph 0.6 onwards, where igraph_integer_t has finally been typedef'd to long int.

[Tamás Nepusz (ntamas)]

Fixed in #2992 in trunk, #2957 in 0.6-main

[Gábor Csárdi (gabor.csardi)]

The development of igraph has moved to github, so please do not comment on this bug here. You are of course welcome to comment on github, here:
https://github.com/igraph/igraph/issues/121