On select toolbar "Object lock"-Button resize icon on clicking

[Alexander Janzen]

On clicking on the mentioned toolbar button it resizes itself. Its may be because it is a small image on a bigger button.
This behavior appears on Windows (7/8) and Ubuntu 12.04, so I think it is a UI-bug.
I tried to track the bug, but I couldn't fixed it.

I think it appears on changing the iconId of the button in:
/inkscape/src/widgets/select-toolbar.cpp : toggle_lock(..)

Maybe there is something missing?

[John Smith (john-smithi)]

Fix committed as r11701.

FYI The problem was in the InkToggleAction widget itself.
When it creates the initial icon it wraps the icon in a GtkAlignment to ensure the icon doesn't resize to fill the whole button's space. But when the button is toggled , the new icon was not wrapped in a GtkAlignment - so was expanding to fill the whole buttons space (might have noticed the icon was blurry). Simple fix is to do the same wrapping when the new icon is set.

[su_v (suv-lp)]

@John - finally! Many thx :-)
(This has been a small but visually annoying issue which AFAICT started with Inkscape 0.47 - glad you took the time to figure out how to fix it.)

[su_v (suv-lp)]

Diff for lp:inkscape/0.48.x

[jazzynico (jazzynico)]

Backported to the branch, revision 9926.