Media keys test shouldn't timeout

Bug #1052572 reported by Ara Pulido
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Medium
Po-Hsu Lin

Bug Description

Right now, media keys test times out after some seconds.
This is not really needed, as the user can always close the window.

Remove the timeout and explain in the test window to close it when done.

Related branches

Ara Pulido (ara)
tags: added: bitesize
Revision history for this message
Brendan Donegan (brendan-donegan) wrote :

Not sure this is *totally* trivial, but shouldn't be too hard and it should be fixed.

Changed in checkbox:
status: New → Triaged
Revision history for this message
Daniel Manrique (roadmr) wrote :

It's very easy to fix, line 398 of scripts/key_test has:

    GObject.timeout_add_seconds(EXIT_TIMEOUT, reporter.quit)

If this is removed, the test will NOT exit after EXIT_TIMEOUT seconds.

Then, each Reporter subclass has a few calls to self.show_text with the text shown to the user. The instructions for the text-mode test already show how to exit it manually:

        self.show_text(_("You can also close me by pressing ESC or Ctrl+C."))

The GtkReporter class doesn't:

        self.show_text(_("Please press each key on your keyboard."))
        self.show_text(_("If a key is not present in your keyboard, "
                         "press the 'Skip' button below it to remove it "
                         "from the test."))

but it's trivial to add.

tags: added: scripts
Zygmunt Krynicki (zyga)
affects: checkbox → plainbox-provider-checkbox
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Same problem could apply to Super key, Volume, and Mute tests

Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
assignee: nobody → Po-Hsu Lin (cypressyew)
Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
status: Triaged → In Progress
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

I think we don't need the instructions for the gtk-mode to show how to exit it manually, as there will be an "Exit" button on it. (Which will return 1 when pressed.)

Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
milestone: none → 0.23
Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Pierre Equoy (pieq)
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.