Exception when adding a Webpage with '&' within the url

Bug #1050867 reported by Josef Biehler
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Xibo
Fix Released
Low
Dan Garner

Bug Description

Hello,

Sometimes i got errors like those in my log:

 <errormsg>DOMDocument::loadXML(): EntityRef: expecting ';' in Entity, line: 200</errormsg>
<errornum>2</errornum>
<errortype>Warning</errortype>
<scriptname>D:\xampp\htdocs\XiboServer\lib\service\xmdssoap.class.php</scriptname>
<scriptlinenum>682</scriptlinenum>

Today i tried to look after the source of these errors.
I put an Debug::LogEntry to line 680 of the xmdssoap class to see what data are causing that.

After analysing this error occurs because there are chars like '&' in the log sent from the client to the server:

</trace><trace date="2012-09-14 11:19:56" category="MainForm - DestoryLayout">Calling Dispose Region
</trace><trace date="2012-09-14 11:19:56" category="Audit">Disposing http://localhost:1234/XiboServer/xibo_ext/modules/display/xibo_weather.connector.php?mod=city&city=Moosbach&zipcode=92709&time=average&day=1&day=0&
</trace><trace date="2012-09-14 11:19:56" category="Audit">Disposed http://localhost:1234/XiboServer/xibo_ext/modules/display/xibo_weather.connector.php?mod=city&city=Moosbach&zipcode=92709&time=average&day=1&day=0&
</trace><trace date="2012-09-14 11:19:56" category="Region - Dispose">Media Disposed by Region

(these regions contain webpages with the urls given in the log. Are Urls with parameter "not supported"?)

I think i can encode the log by changing the client code but before i wanted to know if there is a known bug (and therefore a bugfix for it)?

Im using Xibo 1.2.2 but i have tested it with 1.3 with the same result.

After escaping special chars like '&' to '&amp;' the error doesn't occur anymore.

StR:
1. Place Webpage with url like 'http://localhost/?i=1&b=asd' onto region
2. enable logging
3. Start client
4. close client to force client to dispose its content

Tags: 1.2.2 1.3 xibo

Related branches

tags: added: 1.2.2 xibo
tags: added: 1.3
Changed in xibo:
status: New → Confirmed
importance: Undecided → Low
milestone: none → 1.4.0-rc1
Dan Garner (dangarner)
Changed in xibo:
milestone: 1.4.0-rc1 → 1.5.0
assignee: nobody → Dan Garner (dangarner)
Changed in xibo:
milestone: 1.5.0 → 1.5.1
Dan Garner (dangarner)
Changed in xibo:
milestone: 1.5.1 → 1.5.2
Dan Garner (dangarner)
Changed in xibo:
status: Confirmed → Triaged
Dan Garner (dangarner)
Changed in xibo:
status: Triaged → Fix Committed
Dan Garner (dangarner)
Changed in xibo:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.