Add slip_enabled and beatlooproll_x_activate to Midi wizard and tooltips

Bug #1050597 reported by jus
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Low
jus

Bug Description

This is a follow up to lp:703585 - Slip mode

Patch
* adds support for both controls , slip_enabled and beatlooproll_x_activate, to midi   wizard and tooltips.
* adds some missing tr`s for i18n to midi wizard.
* adds some beatloop_X values currently missing to midi wizard.
  Note: Is it still correct to use the deprecated beatloop_X here instead of beatloop_X_toggle?
* changes the smallest loop size to 0.03125 (1/32th) which sound pretty cool e.g. when   working with loop rolls and and the pitch fader with a wide pitch rate.

I have tested the patch with OSX and a Midi controller.

Please check grammar and spelling in the patch`s tooltips part.

Tags: midi usability

Related branches

Revision history for this message
jus (jus) wrote :
summary: - Add slip_enabled and beatloop_x_activate to Midi wizard and tooltips
+ Add slip_enabled and beatlooproll_x_activate to Midi wizard and tooltips
description: updated
description: updated
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good -- thanks!

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Single grammar change:

"Temporary setup a rolling loop"
Temporary should be Temporarily

Revision history for this message
jus (jus) wrote :

Thanks RJ for looking at.
Regarding my question from #1, we are still fine when using beatloop_X?

Revision history for this message
x (broma0-deactivatedaccount) wrote :

Patch works perfectly for me on revision 3397.

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Hi jus -- I think we should switch to using beatloop_X_toggle. Good catch.

Revision history for this message
jus (jus) wrote :

Updated patch
* Grammar fix
* Use beatloop_X_toggle in dlgcontrollerlearning.cpp
* Use beatloop_X_toggle across all *kbd.cfg, currently we used it only in en_US.kbd.cfg

Im unsure if i need to change from beatloop_X to beatloop_X_toggle in controlvaluedelegate.cpp too, since various controller scripts use still beatloop_X

Revision history for this message
RJ Skerry-Ryan (rryan) wrote : Re: [Bug 1050597] Re: Add slip_enabled and beatlooproll_x_activate to Midi wizard and tooltips

ControlValueDelegate is unused code at the moment since it describes what
controls to show in the drop-down when editing a MIDI mapping. I think
beatloop_X_toggle would be the right thing (or maybe both) to put there as
well.

On Wed, Sep 26, 2012 at 3:16 AM, jus <email address hidden> wrote:

> Updated patch
> * Grammar fix
> * Use beatloop_X_toggle in dlgcontrollerlearning.cpp
> * Use beatloop_X_toggle across all *kbd.cfg, currently we used it only in
> en_US.kbd.cfg
>
> Im unsure if i need to change from beatloop_X to beatloop_X_toggle in
> controlvaluedelegate.cpp too, since various controller scripts use still
> beatloop_X
>
> ** Patch added: "slip_and_roll2.patch"
>
> https://bugs.launchpad.net/mixxx/+bug/1050597/+attachment/3344244/+files/slip_and_roll2.patch
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1050597
>
> Title:
> Add slip_enabled and beatlooproll_x_activate to Midi wizard and
> tooltips
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1050597/+subscriptions
>

Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Committed the patch -- thanks jus.

Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6630

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.