I_S.INNODB_CHANGED_PAGES needs to be added to percona_skip_innodb_i_s.test and return error and check permissions
Bug #1050466 reported by
Stewart Smith
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.1 |
Fix Released
|
Medium
|
Laurynas Biveinis | ||
5.5 |
Fix Released
|
Medium
|
Laurynas Biveinis |
Bug Description
needs a SELECT * line in the test, and then it needs to return error, so the _fill() routine needs something like:
/* deny access to non-superusers */
if (check_
DBUG_RETURN(0);
}
RETURN_
Related branches
lp:~laurynas-biveinis/percona-server/xtradb-multiple-bmp-files-51
- Stewart Smith (community): Approve
- Alexey Kopytov (community): Approve
- Vlad Lesin: Pending requested
-
Diff: 2630 lines (+1500/-497)17 files modifiedPercona-Server/mysql-test/include/delete_innodb_bitmaps.inc (+11/-0)
Percona-Server/mysql-test/r/percona_server_variables_debug.result (+1/-0)
Percona-Server/mysql-test/r/percona_server_variables_release.result (+1/-0)
Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp.result (+32/-2)
Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_page_bmp_no_restart.result (+1/-0)
Percona-Server/mysql-test/suite/innodb_plugin/r/percona_changed_pages.result (+142/-28)
Percona-Server/mysql-test/suite/innodb_plugin/t/innodb_bug34300-master.opt (+0/-1)
Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp.test (+150/-31)
Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_page_bmp_no_restart.test (+10/-2)
Percona-Server/mysql-test/suite/innodb_plugin/t/percona_changed_pages.test (+224/-64)
Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc (+6/-0)
Percona-Server/storage/innodb_plugin/handler/i_s.cc (+184/-122)
Percona-Server/storage/innodb_plugin/include/log0online.h (+77/-27)
Percona-Server/storage/innodb_plugin/include/srv0srv.h (+2/-1)
Percona-Server/storage/innodb_plugin/log/log0online.c (+635/-206)
Percona-Server/storage/innodb_plugin/srv/srv0srv.c (+2/-0)
Percona-Server/storage/innodb_plugin/srv/srv0start.c (+22/-13)
lp:~laurynas-biveinis/percona-server/xtradb-multiple-bmp-files-5.5
- Alexey Kopytov (community): Approve
-
Diff: 2798 lines (+1656/-506)18 files modifiedPercona-Server/mysql-test/include/delete_innodb_bitmaps.inc (+11/-0)
Percona-Server/mysql-test/r/percona_server_variables_debug.result (+1/-0)
Percona-Server/mysql-test/r/percona_server_variables_release.result (+1/-0)
Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp.result (+35/-4)
Percona-Server/mysql-test/suite/innodb/r/percona_changed_page_bmp_no_restart.result (+1/-0)
Percona-Server/mysql-test/suite/innodb/r/percona_changed_pages.result (+142/-28)
Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp.test (+155/-39)
Percona-Server/mysql-test/suite/innodb/t/percona_changed_page_bmp_no_restart.test (+10/-2)
Percona-Server/mysql-test/suite/innodb/t/percona_changed_pages.test (+224/-64)
Percona-Server/mysql-test/suite/sys_vars/r/innodb_max_bitmap_file_size_basic.result (+84/-0)
Percona-Server/mysql-test/suite/sys_vars/t/innodb_max_bitmap_file_size_basic.test (+62/-0)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+6/-0)
Percona-Server/storage/innobase/handler/i_s.cc (+184/-122)
Percona-Server/storage/innobase/include/log0online.h (+77/-27)
Percona-Server/storage/innobase/include/srv0srv.h (+2/-1)
Percona-Server/storage/innobase/log/log0online.c (+637/-206)
Percona-Server/storage/innobase/srv/srv0srv.c (+2/-0)
Percona-Server/storage/innobase/srv/srv0start.c (+22/-13)
tags: | added: i16274 |
To post a comment you must log in.
<stewart> laurynas, ahh... so that test is for with innodb disabled, doing a select * from each I_S table IF_INNODB_ NOT_STARTED( ) CHANGED_ PAGES table doesn't have
laurynas, each Innodb IS table should have a call to RETURN_
laurynas, for which the INNODB_
laurynas, soo... if in error state, could be not so good
<laurynas> stewart: ack... is this for 5.1 too?
<stewart> laurynas, yes
laurynas, should probably also do the ACL check.. and likely limit to super only