I_S.INNODB_CHANGED_PAGES needs to be added to percona_skip_innodb_i_s.test and return error and check permissions

Bug #1050466 reported by Stewart Smith
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona Server moved to https://jira.percona.com/projects/PS
Fix Released
Medium
Laurynas Biveinis
5.1
Fix Released
Medium
Laurynas Biveinis
5.5
Fix Released
Medium
Laurynas Biveinis

Bug Description

needs a SELECT * line in the test, and then it needs to return error, so the _fill() routine needs something like:

 /* deny access to non-superusers */
 if (check_global_access(thd, PROCESS_ACL)) {

  DBUG_RETURN(0);
 }

 RETURN_IF_INNODB_NOT_STARTED(tables->schema_table_name);

Tags: i16274

Related branches

Revision history for this message
Stewart Smith (stewart) wrote :

<stewart> laurynas, ahh... so that test is for with innodb disabled, doing a select * from each I_S table
 laurynas, each Innodb IS table should have a call to RETURN_IF_INNODB_NOT_STARTED()
 laurynas, for which the INNODB_CHANGED_PAGES table doesn't have
 laurynas, soo... if in error state, could be not so good
<laurynas> stewart: ack... is this for 5.1 too?
<stewart> laurynas, yes
 laurynas, should probably also do the ACL check.. and likely limit to super only

tags: added: i16274
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1269

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.