Crash related to 'Dispose' action after using undo and close an image

Bug #1048137 reported by grofaty
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
Fix Released
High
Cameron White

Bug Description

Using Pinta-1.4-preview-20120908 on Windows XP I have been trying to test a bug 996490 and found out a crash which is a regression from previous development preview:
1. Open new image: 300 x 300
2. <Print screen> and paste with <CTRL>+V
3. Accept the "Expand canvas" button.
4. Click on "Undo" toolbar button.
5. File | Close and crash appears:
===================
Unhandled exception:
Exception has been thrown by the target of an invocation.
Details:

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.NullReferenceException: Object reference not set to an instance of an object.
   at Pinta.Core.ResizeHistoryItem.Dispose()
   at Pinta.Core.CompoundHistoryItem.Dispose()
   at Pinta.Core.DocumentWorkspaceHistory.<Clear>b__0(BaseHistoryItem item)
   at System.Collections.Generic.List`1.ForEach(Action`1 action)
   at Pinta.Core.DocumentWorkspaceHistory.Clear()
   at Pinta.Core.Document.Close()
   at Pinta.Core.WorkspaceManager.CloseDocument(Document document)
   at Pinta.Actions.CloseDocumentAction.Activated(Object sender, EventArgs e)
   --- End of inner exception stack trace ---
   at System.RuntimeMethodHandle._InvokeMethodFast(IRuntimeMethodInfo method, Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeType typeOwner)
   at System.RuntimeMethodHandle.InvokeMethodFast(IRuntimeMethodInfo method, Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeType typeOwner)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)
   at System.Delegate.DynamicInvokeImpl(Object[] args)
   at GLib.Signal.ClosureInvokedCB(Object o, ClosureInvokedArgs args)
   at GLib.SignalClosure.Invoke(ClosureInvokedArgs args)
   at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data)
===================

According to the error message this is most probably related to this commit: https://github.com/PintaProject/Pinta/commit/9a999cf874eaa38ac29e598d4a2c630a3317918c

Revision history for this message
grofaty (grofaty) wrote :

I have done some regression tests on Ubuntu 12.04 (checking out the one commit after another) and I have found out that first commit that this regression appears in is "Merge branch 'Magic-Wand-Tool' of https://github.com/mono-soc-2012/Pinta commited" in commit: https://github.com/PintaProject/Pinta/commit/c96e0cc72ebf07f93ef97f4d6df9002fa19f7609

Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
importance: Undecided → High
milestone: none → 1.4
status: New → Confirmed
Revision history for this message
Cameron White (cameronwhite91) wrote :
Changed in pinta:
status: Confirmed → Fix Committed
Revision history for this message
grofaty (grofaty) wrote :

Tested in Pinta-1.4-preview-20120922 on Windows XP and I can report bug is fixed.

Revision history for this message
grofaty (grofaty) wrote :

Pinta v1.4 on Windows XP. Problem solved.

Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.