iscsi volume creation fails (--conf file is not being specified)

[Dan Prince]

Using Cinder 802c05b. I'm getting the following errors when trying to create a volume:

2012-09-06 14:00:35 ERROR cinder.openstack.common.rpc.amqp [-] Exception during message handling
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp Traceback (most recent call last):
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/openstack/common/rpc/amqp.py", line 275, in _process_data
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp rval = self.proxy.dispatch(ctxt, version, method, **args)
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/openstack/common/rpc/dispatcher.py", line 145, in dispatch
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp return getattr(proxyobj, method)(ctxt, **kwargs)
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 153, in create_volume
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp volume_ref['id'], {'status': 'error'})
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib64/python2.7/contextlib.py", line 24, in __exit__
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp self.gen.next()
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/manager.py", line 147, in create_volume
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp model_update = self.driver.create_export(context, volume_ref)
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/driver.py", line 365, in create_export
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp volume_path)
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp File "/usr/lib/python2.7/site-packages/cinder/volume/iscsi.py", line 145, in create_iscsi_target
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp raise exception.NotFound()
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp NotFound: Resource could not be found.
2012-09-06 14:00:35 TRACE cinder.openstack.common.rpc.amqp

-----

The issue appears to be that we no longer specify a --conf file in the iscsi driver for Cinder. The driver still appears to write out a config file but *nothing* is using it.

I traced the cause down to this commit: https://github.com/openstack/cinder/commit/9785963c841aff5ea1c159da81f93c2bf62c70c6

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12517

[Dan Prince (dan-prince)]

Now that we've merged this breaking commit to Nova it fails as well on master. Using nova-volume on Fedora 17 this is what I'm now seeing as of today (nova revision 0de7b3b) :

VolumeTests
    test_000_setUp OK
    test_001_can_create_volume OK
    test_002_can_attach_volume FAIL
    test_003_can_mount_volume FAIL
    test_004_can_write_to_volume OK
    test_005_volume_is_correct_size FAIL
    test_006_me_can_umount_volume FAIL
    test_007_me_can_detach_volume ERROR
    test_008_me_can_delete_volume OK
    test_999_tearDown OK

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12517
Committed: http://github.com/openstack/cinder/commit/0903603971033536751ba40df98a3c39175d3189
Submitter: Jenkins
Branch: master

commit 0903603971033536751ba40df98a3c39175d3189
Author: Dan Prince <email address hidden>
Date: Thu Sep 6 14:50:50 2012 -0400

    Specify the conf file when creating a volume.

    Updates the tgt-admin command to actually use the config file
    we create for the volume being created.

    This fixes an issue introduced in
    9785963c841aff5ea1c159da81f93c2bf62c70c6 which breaks iscsi
    volume creation.

    Fixes LP Bug #1046985.

    Change-Id: I06e83c9ba351c2b4846b557a3abb170a51d506c0

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/12542

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/12542
Committed: http://github.com/openstack/nova/commit/0a09bf5faeb30b675fdb8f517c61166ef794bad3
Submitter: Jenkins
Branch: master

commit 0a09bf5faeb30b675fdb8f517c61166ef794bad3
Author: Dan Prince <email address hidden>
Date: Thu Sep 6 23:03:50 2012 -0400

    Specify the conf file when creating a volume.

    Updates the tgt-admin command to actually use the config file
    we create for the volume being created.

    This fixes an issue introduced in
    66f6a9edce3ccd624aba5d2a6bf3362901ed57f7 which breaks iscsi
    volume creation.

    Fixes LP Bug #1046985.

    Change-Id: I58bd23ef6dd0055a329ace8e4b09d86886aa38e9