Checker failures: FacebookApps.user.js and GooglePlusGames.user.js

Bug #1046846 reported by Víctor R. Ruiz
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
WebApps: Applications Data
Fix Released
Critical
Unassigned
unity-webapps-googleplusgames (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

find ../src | grep -e "\.js$" | xargs -L 1 ../scripts/style_checker.js ../scripts/third_party/jslint.js && \
 ../scripts/icon_uris_checker.sh ..
../src/FacebookApps/FacebookApps.user.js:48->Expected 'domain' at column 17, not column 14.

../src/GooglePlusGames/GooglePlusGames.user.js:59->Expected 'domain' at column 21, not column 18.

On webapps-applications revno:342

Related branches

Maxim Ermilov (zaspire)
Changed in webapps-applications:
status: New → Fix Committed
Robert Carr (robertcarr)
Changed in webapps-applications:
status: Fix Committed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in webapps-applications (Ubuntu Raring):
status: New → Confirmed
Revision history for this message
Robert Bruce Park (robru) wrote :

Victor, this bug is from last August! I told you that style_checker.js has not been working since August...

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Well, this particualr bug report was related to a couple of scripts, not to style_checker.js itself.

Revision history for this message
Robert Bruce Park (robru) wrote :

I know, but I'm just saying this is the last known time that style_checker.js ever did anything. Since then it has been dormant and not catching errors... or at least that's what I thought at the time that I wrote comment #2. Now I'm not sure what to believe.

Revision history for this message
Víctor R. Ruiz (vrruiz) wrote :

Anyway, let's fix it.

Changed in unity-webapps-googleplusgames (Ubuntu):
status: New → Fix Committed
status: Fix Committed → Fix Released
no longer affects: webapps-applications (Ubuntu Raring)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.