Ignore images that are tagged with a specific keyword

[Paulo Roberto de Oliveira Castro]

Sometimes I just don't want to "girls" or "women" photos to pop up into my desktop (what would my girlfriend think!?). Then, I wish that Variety had an option to ignore wallpapers that were marked with "women" or any other word when downloading them.

[Peter Levi (peterlevi)]

This is very good to have, and other people have also requested it, but is quite some work to implement and I don't have much time at the moment. Still, it will definitely land in Variety at some point.

Steps necessary:

1. Hardest one. Implement keywords/tags extraction for every online source:

For Flickr this means additional API calls which may turn out a problem in the future. Flickr limits the number of free API calls allowed per day and at the moment we are very frugal in this aspect - one API call to fill the download queue with tens or hundreds of images. If we need to extract tags, that's another API call for every image in the queue.

For Wallbase and Wallpapers.net this means more scraping code and potential breakage in the future.

MediaRSS (support not yet implemented) does not have a clear convention for listing tags. media:category seems to be the usual place for placing tags, but can we rely on it - needs investigation.

2. Save tags into the images - IPTC Keywords seems like the good place for these, and we may want to duplicate in a Variety-specific tag. Needs more investigation.

3. Implement filtering based on the saved tags. As with any other filtering, this slows down the searching for images and means more CPU/HDD usage from time to time when the prepared queue is exhausted.

[Grzegorz G. (grzesiek1e5)]

You may want to implement filtering by existing tags first (I mean tag metadata of images that are already on HDD and have been manually tagged). It'll be easier.

[icb410 (ian-berke)]

In the short-term, how about implementing a black-list so that images you don't like won't reappear if they've been added to it. Should be fairly simple to name-check a downloaded image with a blacklist before changing the wallpaper.

[Peter Levi (peterlevi)]

This is already done - deleting to Trash also adds to a blacklist (~/.config/variety/banned.txt) and you shouldn't see this image again, at least not from the same URL. Wallbase however has many duplicate images (with slight variations in color, image compression, etc.), and you may also see the same image from another source (Wallpapers.net, etc.).

[icb410 (ian-berke)]

Ahh... there may be a bug here. No banned.txt file was present in the config directory. Clicking "Delete to Trash" did not create one either. I had to create the file manually with "touch ~/.config/variety/banned.txt". Now when I delete images, they show up in the file.

You may want to do a file check to make sure banned.txt exists and create it before adding deleted urls to it. I upgraded from an older version so I don't know if this causes an issue or not.

[Peter Levi (peterlevi)]

Might be a bug. But the code looks good and it works OK on my machine (file is opened with "append" mode so if it is not there, it should be automatically created).
Are you sure the deleted image was coming from an online source and was not a local image? Please delete the existing banned.txt in ~/.config/variety, then run variety from terminal with "-v" option and give it a try again by deleting some non-local wallpaper - you should see an option "View at xxx" in the menu for the image. And if you can confirm it's misbehaving, please report it as a separate bug and we'll track it down.

[icb410 (ian-berke)]

Weird... it works now. Thanks for the quick responses