glance-manage should not require glance-registry.conf

[Mark Washenberger]

glance-manage gets its sql connection info from glance-registry.conf. However, with api v2 it is not required that you even deploy a registry. Somehow glance-manage needs to be smarter about all this.

[Brian Waldon (bcwaldon)]

You can use --config-file to get around this, but we could be better about handling it.

[John Bresnahan (jbresnah)]

This seems like a very easy fix. From looking at the tests, the only required information for glance-manage appears to be 'sql_connection'. This field is in both so we can simply point at the api file. However we should probably add a few more tests for glance-manage.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/25829

[Mark Washenberger (markwash)]

Could glance-manage take the sql connection as an argument as well?

[John Bresnahan (jbresnah)]

That sounds like a good feature. So it would take that on the command line and that would override anything in a configuration file?

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/25829
Committed: http://github.com/openstack/glance/commit/3e0f3d502d9cd885091561ac5172a14fffe30fd3
Submitter: Jenkins
Branch: master

commit 3e0f3d502d9cd885091561ac5172a14fffe30fd3
Author: John Bresnahan <email address hidden>
Date: Mon Apr 1 08:42:57 2013 -1000

    glance-manage should not require glance-registry.conf

    In v2 the glance-registry service is no longer needed. Thus
    it is possible that a setup would not include a configuration
    file for it at all. Further it is possible that glance-api and
    glance-registry be run on different machines such that neither
    configuration file is available to the other. Therefore glance-manage
    should be able to pull the information out of either configuration
    file provided that the overriding command line options:
    --sql_connection or --config-file are not used. This patch makes
    it so glance-manage will first look in the glance-registry.conf file
    for db information (as this is the legacy behavior) and then in
    the glance-api.conf file if that file does not exist.

    Fixes bug: 1046576
    Change-Id: Ida68a5c03eb3d188b2b997296cd45730b968ef12