Minor fixes in the mstate presence watching logic
Bug #1046575 reported by
Gustavo Niemeyer
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
Gustavo Niemeyer |
Bug Description
These comments were made in a review, but the branch ended up moving on without them. We should come back to it soon:
- We need to observe the Dying of the presence watcher, whenever added channels are used. The Dying method doesn't exist yet.
- We should guarantee that Alive always returns true after a false, and that's not true right now because alive may have to return when facing a dead presence.Watcher. We need to return an additional error result with Watcher's Alive method so that one can tell if the false result is real or not.
Related branches
lp:~niemeyer/juju-core/presence-polishing
- The Go Language Gophers: Pending requested
-
Diff: 960 lines (+319/-209)9 files modifiedmstate/machine.go (+19/-25)
mstate/machine_test.go (+13/-10)
mstate/open.go (+3/-3)
mstate/presence/presence.go (+88/-74)
mstate/presence/presence_test.go (+137/-37)
mstate/state.go (+19/-19)
mstate/unit.go (+23/-26)
mstate/unit_test.go (+15/-10)
mstate/watcher/watcher_test.go (+2/-5)
Changed in juju-core: | |
status: | New → Confirmed |
importance: | Undecided → High |
milestone: | none → 1.3 |
Changed in juju-core: | |
assignee: | nobody → Gustavo Niemeyer (niemeyer) |
status: | Confirmed → In Progress |
milestone: | 1.3 → 1.4 |
Changed in juju-core: | |
milestone: | 1.9.1 → 1.9.2 |
Changed in juju-core: | |
status: | In Progress → Fix Released |
To post a comment you must log in.