UNIV_DEBUG build broken

[Laurynas Biveinis]

To reproduce, add -DUNIV_DEBUG to extra_flags in compile-percona-debug (not in the tree yet).

Current Percona Server 5.1 trunk (rev 477):

gcc -DHAVE_CONFIG_H -I. -I../../include -I../../include -I../../include -I../../regex -I./include -I../../sql -I. -Wall -Wextra -Wunused -Wwrite-strings -Wno-strict-aliasing -Werror -Wdeclaration-after-statement -g -DSAFE_MUTEX -DSAFEMALLOC -Wall -Wextra -Wunused -Wwrite-strings -mtune=native -DUNIV_MUST_NOT_INLINE -DEXTRA_DEBUG -DFORCE_INIT_OF_VARS -DSAFEMALLOC -DPEDANTIC_SAFEMALLOC -DSAFE_MUTEX -D_FORTIFY_SOURCE=2 -fmessage-length=0 -g3 -DUNIV_DEBUG -DUNIV_LINUX -MT libinnobase_a-buf0buf.o -MD -MP -MF .deps/libinnobase_a-buf0buf.Tpo -c -o libinnobase_a-buf0buf.o `test -f 'buf/buf0buf.c' || echo './'`buf/buf0buf.c
buf/buf0buf.c: In function ‘buf_page_get_gen’:
buf/buf0buf.c:2134:14: error: ‘page_no’ undeclared (first use in this function)
buf/buf0buf.c:2134:14: note: each undeclared identifier is reported only once for each function it appears in
make[2]: *** [libinnobase_a-buf0buf.o] Error 1
make[2]: Leaving directory `/home/laurynas/percona/src/percona-server-5.1/Percona-Server/storage/innodb_plugin'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/laurynas/percona/src/percona-server-5.1/Percona-Server/storage'
make: *** [all-recursive] Error 1

Current MySQL 5.1 trunk builds fine with the same script.

[zhai weixiang (zhaiwx1987)]

Hi, I've directly port this patch to our branch(based on Percona-Server-5.5.18) , and observed an assert failure caused by this line :

28 + ulint page_no = buf_block_get_page_no(block);

#6 0x00000000009f28d6 in buf_block_get_page_no (block=0x2b88c3195b50) at /u01/mysqltest/source/Percona-Server-5.5.18/storage/innobase/include/buf0buf.ic:727
727 ut_a(buf_block_get_state(block) == BUF_BLOCK_FILE_PAGE);
(gdb) p block->page.state
$5 = 3

any advise ?

[Laurynas Biveinis (laurynas-biveinis)]

Zhai -

What exactly did you port? The patch for this bug was applicable to 5.1 only, not 5.5.

[zhai weixiang (zhaiwx1987)]

Please ignore all my comments, sorry :(

... my mistake ... I should check the block state first ...

[zhai weixiang (zhaiwx1987)]

I just ported the patch at this bug report : https://bugs.launchpad.net/percona-server/+bug/905334, and added this line manually:

28 + ulint page_no = buf_block_get_page_no(block);

Actually the patch of bug#905334 is incomplete, it should be combined with the patch of bug#1046389

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-2800