Pull list shows multiple rows for same hold/copy

[Ben Shum]

Evergreen master

We've noticed that occasionally in our hold pull list, there will be the same item showing 2-6 times over. Looking further, we can see that the items are not targeting different holds, but in fact are simply duplicates of the same hold being displayed over and over (hold ID is the same, along with copy target).

So at least our libs aren't pulling copies and trying to fill more holds with them. But it does lead to a very confusing pull list to work through.

[Ben Shum (bshum)]

Before jumping to conclusions about new-xul, checking to see if maybe there are other factors involved with the hold pull list...

[Lebbeous Fogle-Weekley (lebbeous)]

To be clear, since we have an embarrassment of pull list interfaces now, which one are we talking about here?

The XUL-based one (the first one you arrive at in the staff client clicking the pull list menu option under the Circulation heading)?
The "alternate-strategy" pull list?
The "simplified" pull list?

[Lebbeous Fogle-Weekley (lebbeous)]

You just answered this in IRC before I asked you there, so I'm pasting what you said here:

16:42 < bshum> Looks like the multiple rows issue is only happening on the xul
               view. The simplified pull list isn't showing us duplicates so
               far. We're testing further.

[Steve Callender (stevecallender)]

I came across this today on 2.3. In the examples I've seen, it was just happening in "C" holds. I don't know if that's relevant or not, but figured it was worth mentioning in case someone else notices a pattern.

[Chris Sharp (chrissharp123)]

This may need to be a separate bug, but I've seen this same behavior in the Transit List UI as well. I'm blindly assuming a similar backend function is involved?

[Ben Shum (bshum)]

Unfortunately I can see cases where the duplication is occurring with title holds too. So I'm afraid it's not just copy holds being duped, but all the holds at varying stages.

It's not always the case, but oftentimes the duplicated lines seem to appear towards the points where you begin to need to scroll. Maybe it's some weird retrieval issue and the interface is adding more lines as it tries to get information retrieved.

[Ben Shum (bshum)]

Screenshot showing an example of the duplicated row effect we're seeing with the pull list interface. As you can see, we sometimes get many rows with the same exact hold ID, copy target, etc.

[Tony Bandy (tonyb-y-deactivatedaccount)]

Not sure of the status with this, but as of May 2013 and late last year, we have noticed this issue showing up in our pull lists as well. We are currently running 2.3.6.

[[e-mail] (tji)]

I see this on 2.4 beta with title holds. The duplicates are displayed right after clicking Pull List for Holds from Circ menu.

When using Print Full Pull List, the dups are printed as shown on the screen.
When using Alternate Strategy, no dups but some funny thing at the bottom. See the attachment.

Both display and printing on Simplified Pull list interface do not have dups (at least so far). But it is extremely slow to load the page.

Tina
Sitka

[Chris Sharp (chrissharp123)]

I'll add another "me too" to this bug. My previous post referred to an apparently related bug that has not recurred in 2.3 to my knowledge. We had two libraries report this issue, and I was able to confirm the repeated rows in the default Holds Pull List interface (and was able to confirm that duplicates are not present in the alternate pull list).

[Mike Rylander (mrylander)]

I didn't even know this bug existed! Jason Etheridge alerted me to an instance of this yesterday and I whipped up the following branch:

http://git.evergreen-ils.org/?p=working/Evergreen.git;a=shortlog;h=refs/heads/user/miker/avoid-dupe-hold-on-list

[Ben Shum (bshum)]

I'm so glad I noticed this change Mike. I tested this and it looks to be keeping the duplicate rows from showing up in our hold pull lists.

I am sure so many people in our consortium will really appreciate this bug fix.

Thanks!

Pushed to master, rel_2_5 and rel_2_4 (with some tiny whitespace vs. tab fixups for 2.4).