Delete file triggers 'CommunityFile' object has no attribute '__parent__'

[JimPGlenn]

There are two deletes for files the delete button at the individual file ends in a general error see screencast.

I found this in the error monitor:

AttributeError: 'CommunityFile' object has no attribute '__parent__'
Exception when processing https://karl.soros.org/communities/tester/files/testsearch.docx/delete.html?confirm=1
Referer: https://karl.soros.org/communities/tester/files/testsearch.docx/delete.html

Traceback (most recent call last):
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/tweens.py", line 17, in excview_tween
    response = handler(request)
  File "/srv/osfkarl/production/4/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 107, in tm_tween
    return response
  File "/srv/osfkarl/production/4/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 75, in __exit__
    return self._retry_or_raise(t, v, tb)
  File "/srv/osfkarl/production/4/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 60, in _retry_or_raise
    reraise(t, v, tb) # otherwise reraise the exception
  File "/srv/osfkarl/production/4/eggs/pyramid_tm-0.5-py2.6.egg/pyramid_tm/__init__.py", line 100, in tm_tween
    response = handler(request)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/router.py", line 153, in handle_request
    response = view_callable(context, request)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 186, in _secured_view
    return view(context, request)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/config/views.py", line 292, in rendered_view
    result = view(context, request)
  File "/srv/osfkarl/production/4/eggs/karl-3.93-py2.6.egg/karl/views/resource.py", line 39, in delete_resource_view
    del context.__parent__[context.__name__]
  File "/srv/osfkarl/production/4/eggs/repoze.folder-0.6.2-py2.6.egg/repoze/folder/__init__.py", line 151, in __delitem__
    return self.remove(name)
  File "/srv/osfkarl/production/4/eggs/repoze.folder-0.6.2-py2.6.egg/repoze/folder/__init__.py", line 180, in remove
    objectEventNotify(ObjectRemovedEvent(other, self, name))
  File "/srv/osfkarl/production/4/eggs/zope.component-3.6.0-py2.6.egg/zope/component/event.py", line 33, in objectEventNotify
    adapters = zope.component.subscribers((event.object, event), None)
  File "/srv/osfkarl/production/4/eggs/zope.component-3.6.0-py2.6.egg/zope/component/_api.py", line 138, in subscribers
    return sitemanager.subscribers(objects, interface)
  File "/srv/osfkarl/production/4/eggs/zope.component-3.6.0-py2.6.egg/zope/component/registry.py", line 315, in subscribers
    return self.adapters.subscribers(objects, provided)
  File "/srv/osfkarl/production/4/eggs/zope.interface-3.5.1-py2.6-linux-i686.egg/zope/interface/adapter.py", line 535, in subscribers
    subscription(*objects)
  File "/srv/osfkarl/production/4/eggs/karl-3.93-py2.6.egg/karl/models/subscribers.py", line 222, in delete_in_repo
    user = authenticated_userid(request)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/security.py", line 67, in authenticated_userid
    return policy.authenticated_userid(request)
  File "/srv/osfkarl/production/4/eggs/pyramid_multiauth-0.1.2-py2.6.egg/pyramid_multiauth/__init__.py", line 55, in authenticated_userid
    userid = policy.authenticated_userid(request)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/authentication.py", line 48, in authenticated_userid
    callback_ok = self.callback(userid, request)
  File "/srv/osfkarl/production/4/eggs/karl-3.93-py2.6.egg/karl/application.py", line 93, in group_finder
    users = find_users(request.context)
  File "/srv/osfkarl/production/4/eggs/karl-3.93-py2.6.egg/karl/utils.py", line 49, in find_users
    return getattr(find_site(context), 'users', None)
  File "/srv/osfkarl/production/4/eggs/karl-3.93-py2.6.egg/karl/utils.py", line 45, in find_site
    site = find_root(context)
  File "/srv/osfkarl/production/4/eggs/pyramid-1.2.1-py2.6.egg/pyramid/traversal.py", line 26, in find_root
    if location.__parent__ is None:
AttributeError: 'CommunityFile' object has no attribute '__parent__'

[JimPGlenn (jpglenn09)]

screencast

[Paul Everitt (paul-agendaless)]

Carlos, I haven't looked to see if I can recreate this locally.

[Carlos de la Guardia (cguardia)]

The new group finder tried to traverse the file objects, which are not traversable (no __parent__). Added condition to avoid this and pushed to cguardia-delete-file.

[Chris Rossi (chris-archimedeanco)]

Carlos's fix didn't look right to me so I tested locally and got the exact same problem. The real issue here is that Repozitory is trying to get a user's identity by traversing to root.users from the current context, which, unfortunately, has been detached from the tree because it's just been deleted. This also causes errors found in the error monitor when users attempt to delete wiki pages.

I have committed a different fix to the 'fix-delete' branch. Both file and wiki page deletion should be tested on this branch.

[Paul Everitt (paul-agendaless)]

Jim, can you test this on karldev fix-delete branch? See if this and the "can't search for ozarkia" issue have been fixed.

[JimPGlenn (jpglenn09)]

fix_delete branch worked perfect for search and for delete.

[JimPGlenn (jpglenn09)]

fixed