Core dump in StelQGLRenderer
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Stellarium |
Fix Released
|
Medium
|
Ferdinand Majerech |
Bug Description
Noticed an arithmetic exception and a core dump with the recent changes. A division by zero in StelQGLRenderer
Program terminated with signal 8, Arithmetic exception.
#0 0x00000000005ddd03 in StelQGLRenderer
at /home/sibi/
271 const float charWidth = painter.
(gdb) bt
#0 0x00000000005ddd03 in StelQGLRenderer
at /home/sibi/
#1 0x00000000005de5d8 in StelQGLRenderer
at /home/sibi/
#2 0x000000000081064f in TextUserInterfa
at /home/sibi/
#3 0x000000000058ac93 in StelModule:
Would be good to check the string size before going ahead. Something like this.
const int charCount = string.length();
+
+ if (!charCount)
+ {
+ return;
+ }
+
const float charWidth = painter.
Or better yet, check the string params in drawText().
The TUI plugin forwarded an empty string for selected object (no object selected and empty). So perhaps some optimization in there too.
- if (selectedObj.
- objInfo = "";
- } else {
+ if (!selectedObj.
}
Related branches
- treaves: Needs Fixing
-
Diff: 69550 lines (+19192/-43349)197 files modified.bzrignore (+1/-0)
CMakeLists.txt (+1/-0)
Doxyfile.cmake (+4/-4)
data/default_config.ini (+2/-1)
data/shaders/xyYToRGB.glsl (+34/-32)
doc/codingConventions.doxygen (+0/-2)
doc/doc-header.html (+1/-0)
doc/mainpage.doxygen (+33/-7)
doc/renderer-api-overview.svg (+658/-0)
doc/renderer-implementation-overview.svg (+835/-0)
doc/renderer.doxygen (+421/-0)
doc/scripting.doxygen (+2/-2)
doc/stellarium-architecture.svg (+25/-30)
plugins/AngleMeasure/src/AngleMeasure.cpp (+29/-38)
plugins/AngleMeasure/src/AngleMeasure.hpp (+1/-1)
plugins/CompassMarks/src/CompassMarks.cpp (+19/-30)
plugins/CompassMarks/src/CompassMarks.hpp (+1/-1)
plugins/Exoplanets/src/Exoplanet.cpp (+16/-17)
plugins/Exoplanets/src/Exoplanet.hpp (+3/-7)
plugins/Exoplanets/src/Exoplanets.cpp (+31/-20)
plugins/Exoplanets/src/Exoplanets.hpp (+5/-6)
plugins/HelloStelModule/src/HelloStelModule.cpp (+5/-6)
plugins/HelloStelModule/src/HelloStelModule.hpp (+1/-1)
plugins/LogBook/src/LogBook.cpp (+1/-10)
plugins/LogBook/src/LogBook.hpp (+1/-1)
plugins/Observability/src/Observability.cpp (+13/-15)
plugins/Observability/src/Observability.hpp (+1/-1)
plugins/Oculars/src/Oculars.cpp (+120/-96)
plugins/Oculars/src/Oculars.hpp (+6/-6)
plugins/Pulsars/src/Pulsar.cpp (+13/-17)
plugins/Pulsars/src/Pulsar.hpp (+4/-7)
plugins/Pulsars/src/Pulsars.cpp (+38/-24)
plugins/Pulsars/src/Pulsars.hpp (+4/-6)
plugins/Quasars/src/Quasar.cpp (+19/-22)
plugins/Quasars/src/Quasar.hpp (+3/-6)
plugins/Quasars/src/Quasars.cpp (+37/-27)
plugins/Quasars/src/Quasars.hpp (+4/-6)
plugins/Satellites/src/Satellite.cpp (+23/-25)
plugins/Satellites/src/Satellite.hpp (+11/-13)
plugins/Satellites/src/Satellites.cpp (+54/-30)
plugins/Satellites/src/Satellites.hpp (+4/-3)
plugins/SolarSystemEditor/src/SolarSystemEditor.cpp (+1/-1)
plugins/SolarSystemEditor/src/SolarSystemEditor.hpp (+1/-1)
plugins/SolarSystemEditor/src/gui/ManualImportWindow.cpp (+3/-10)
plugins/SolarSystemEditor/src/gui/ManualImportWindow.hpp (+2/-3)
plugins/Supernovae/src/Supernova.cpp (+8/-11)
plugins/Supernovae/src/Supernova.hpp (+2/-6)
plugins/Supernovae/src/Supernovae.cpp (+32/-25)
plugins/Supernovae/src/Supernovae.hpp (+3/-7)
plugins/TelescopeControl/src/TelescopeControl.cpp (+66/-34)
plugins/TelescopeControl/src/TelescopeControl.hpp (+4/-6)
plugins/TextUserInterface/src/TextUserInterface.cpp (+22/-16)
plugins/TextUserInterface/src/TextUserInterface.hpp (+1/-1)
plugins/TimeZoneConfiguration/src/TimeZoneConfiguration.hpp (+1/-1)
src/CLIProcessor.cpp (+1/-1)
src/CMakeLists.txt (+70/-32)
src/StelMainGraphicsView.cpp (+29/-70)
src/StelMainGraphicsView.hpp (+5/-6)
src/StelMainWindow.cpp (+2/-2)
src/StelMainWindow.hpp (+1/-1)
src/core/OctahedronPolygon.cpp (+33/-34)
src/core/OctahedronPolygon.hpp (+30/-11)
src/core/RefractionExtinction.cpp (+25/-13)
src/core/RefractionExtinction.hpp (+103/-8)
src/core/StelApp.cpp (+23/-30)
src/core/StelApp.hpp (+14/-19)
src/core/StelAppGraphicsWidget.cpp (+73/-110)
src/core/StelAppGraphicsWidget.hpp (+8/-18)
src/core/StelCore.cpp (+62/-16)
src/core/StelCore.hpp (+3/-2)
src/core/StelFileMgr.hpp (+3/-3)
src/core/StelLoadingBar.cpp (+32/-26)
src/core/StelLoadingBar.hpp (+4/-5)
src/core/StelModule.cpp (+2/-2)
src/core/StelModule.hpp (+10/-5)
src/core/StelMovementMgr.hpp (+1/-1)
src/core/StelObject.hpp (+1/-1)
src/core/StelObjectMgr.hpp (+2/-2)
src/core/StelObserver.cpp (+1/-1)
src/core/StelPainter.cpp (+0/-2206)
src/core/StelPainter.hpp (+0/-437)
src/core/StelProjector.cpp (+1/-13)
src/core/StelProjector.hpp (+164/-13)
src/core/StelProjectorClasses.hpp (+154/-1)
src/core/StelSkyDrawer.cpp (+170/-285)
src/core/StelSkyDrawer.hpp (+75/-37)
src/core/StelSkyImageTile.cpp (+53/-41)
src/core/StelSkyImageTile.hpp (+12/-9)
src/core/StelSkyLayer.hpp (+5/-4)
src/core/StelSkyLayerMgr.cpp (+7/-10)
src/core/StelSkyLayerMgr.hpp (+1/-1)
src/core/StelSkyPolygon.cpp (+11/-15)
src/core/StelSkyPolygon.hpp (+3/-3)
src/core/StelSphereGeometry.cpp (+773/-102)
src/core/StelSphereGeometry.hpp (+381/-83)
src/core/StelTexture.cpp (+0/-263)
src/core/StelTexture.hpp (+0/-189)
src/core/StelTextureMgr.cpp (+0/-163)
src/core/StelTextureMgr.hpp (+0/-67)
src/core/StelTextureTypes.hpp (+0/-34)
src/core/StelUtils.cpp (+20/-7)
src/core/StelUtils.hpp (+7/-3)
src/core/StelVertexArray.cpp (+0/-131)
src/core/StelVertexArray.hpp (+0/-166)
src/core/StelViewportEffect.cpp (+382/-229)
src/core/StelViewportEffect.hpp (+71/-22)
src/core/TrailGroup.cpp (+93/-34)
src/core/TrailGroup.hpp (+38/-8)
src/core/TriangleIterator.hpp (+135/-0)
src/core/Triplet.hpp (+41/-0)
src/core/VecMath.hpp (+14/-14)
src/core/external/GLee.c (+0/-18170)
src/core/external/GLee.h (+0/-17646)
src/core/modules/Atmosphere.cpp (+286/-275)
src/core/modules/Atmosphere.hpp (+49/-32)
src/core/modules/Comet.cpp (+0/-3)
src/core/modules/Constellation.cpp (+133/-68)
src/core/modules/Constellation.hpp (+53/-12)
src/core/modules/ConstellationMgr.cpp (+70/-77)
src/core/modules/ConstellationMgr.hpp (+15/-6)
src/core/modules/GeodesicGridDrawer.hpp (+2/-0)
src/core/modules/GridLinesMgr.cpp (+211/-181)
src/core/modules/GridLinesMgr.hpp (+1/-1)
src/core/modules/LabelMgr.cpp (+57/-44)
src/core/modules/LabelMgr.hpp (+3/-2)
src/core/modules/Landscape.cpp (+346/-191)
src/core/modules/Landscape.hpp (+114/-27)
src/core/modules/LandscapeMgr.cpp (+32/-27)
src/core/modules/LandscapeMgr.hpp (+20/-20)
src/core/modules/Meteor.cpp (+192/-185)
src/core/modules/Meteor.hpp (+17/-3)
src/core/modules/MeteorMgr.cpp (+8/-13)
src/core/modules/MeteorMgr.hpp (+1/-1)
src/core/modules/MilkyWay.cpp (+48/-34)
src/core/modules/MilkyWay.hpp (+10/-4)
src/core/modules/MinorPlanet.cpp (+0/-3)
src/core/modules/Nebula.cpp (+62/-37)
src/core/modules/Nebula.hpp (+25/-8)
src/core/modules/NebulaMgr.cpp (+61/-44)
src/core/modules/NebulaMgr.hpp (+7/-5)
src/core/modules/Planet.cpp (+647/-218)
src/core/modules/Planet.hpp (+159/-39)
src/core/modules/SolarSystem.cpp (+220/-40)
src/core/modules/SolarSystem.hpp (+23/-5)
src/core/modules/StarMgr.cpp (+42/-31)
src/core/modules/StarMgr.hpp (+5/-5)
src/core/modules/ZoneArray.cpp (+51/-45)
src/core/modules/ZoneArray.hpp (+16/-15)
src/core/renderer/GenericVertexTypes.hpp (+73/-0)
src/core/renderer/StelCircleArcRenderer.hpp (+344/-0)
src/core/renderer/StelGLSLShader.hpp (+327/-0)
src/core/renderer/StelGLUtilityFunctions.cpp (+80/-0)
src/core/renderer/StelGLUtilityFunctions.hpp (+362/-0)
src/core/renderer/StelGeometryBuilder.cpp (+600/-0)
src/core/renderer/StelGeometryBuilder.hpp (+792/-0)
src/core/renderer/StelIndexBuffer.hpp (+197/-0)
src/core/renderer/StelLight.hpp (+42/-0)
src/core/renderer/StelQGL1ArrayVertexBufferBackend.cpp (+153/-0)
src/core/renderer/StelQGL1ArrayVertexBufferBackend.hpp (+58/-0)
src/core/renderer/StelQGL1Renderer.hpp (+212/-0)
src/core/renderer/StelQGL2ArrayVertexBufferBackend.cpp (+175/-0)
src/core/renderer/StelQGL2ArrayVertexBufferBackend.hpp (+64/-0)
src/core/renderer/StelQGL2Renderer.hpp (+590/-0)
src/core/renderer/StelQGLArrayVertexBufferBackend.cpp (+215/-0)
src/core/renderer/StelQGLArrayVertexBufferBackend.hpp (+254/-0)
src/core/renderer/StelQGLGLSLShader.cpp (+212/-0)
src/core/renderer/StelQGLGLSLShader.hpp (+552/-0)
src/core/renderer/StelQGLIndexBuffer.hpp (+141/-0)
src/core/renderer/StelQGLRenderer.cpp (+561/-0)
src/core/renderer/StelQGLRenderer.hpp (+615/-0)
src/core/renderer/StelQGLTextureBackend.cpp (+533/-0)
src/core/renderer/StelQGLTextureBackend.hpp (+202/-0)
src/core/renderer/StelQGLViewport.cpp (+30/-0)
src/core/renderer/StelQGLViewport.hpp (+460/-0)
src/core/renderer/StelRenderer.cpp (+39/-0)
src/core/renderer/StelRenderer.hpp (+736/-0)
src/core/renderer/StelTextureBackend.hpp (+239/-0)
src/core/renderer/StelTextureCache.hpp (+174/-0)
src/core/renderer/StelTextureLoader.hpp (+204/-0)
src/core/renderer/StelTextureNew.cpp (+31/-0)
src/core/renderer/StelTextureNew.hpp (+134/-0)
src/core/renderer/StelTextureParams.hpp (+113/-0)
src/core/renderer/StelVertexAttribute.hpp (+245/-0)
src/core/renderer/StelVertexBuffer.hpp (+304/-0)
src/core/renderer/StelVertexBufferBackend.hpp (+164/-0)
src/gui/ConfigurationDialog.cpp (+3/-0)
src/gui/StelGui.hpp (+2/-2)
src/gui/StelScriptSyntaxHighlighter.cpp (+1/-1)
src/gui/configurationDialog.ui (+28/-21)
src/noGui/StelNoGui.hpp (+2/-2)
src/scripting/ScreenImageMgr.cpp (+2/-1)
src/scripting/ScreenImageMgr.hpp (+4/-5)
src/tests/testStelVertexArray.cpp (+0/-108)
src/tests/testStelVertexArray.hpp (+0/-40)
src/tests/testStelVertexBuffer.cpp (+129/-0)
src/tests/testStelVertexBuffer.hpp (+28/-0)
util/texture_check.pl (+1/-1)
summary: |
- Seg fault in StelQGLRenderer + Core dump in StelQGLRenderer |
Changed in stellarium: | |
assignee: | nobody → Ferdinand Majerech (kiithsacmp) |
status: | New → In Progress |
importance: | Undecided → Medium |
milestone: | none → 0.12.0 |
Changed in stellarium: | |
status: | In Progress → Fix Committed |
Changed in stellarium: | |
status: | Fix Committed → Fix Released |